You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jono-morris (via GitHub)" <gi...@apache.org> on 2023/12/21 12:49:16 UTC
[PR] CAMEL-20019: demo session handler implementation [camel]
jono-morris opened a new pull request, #12530:
URL: https://github.com/apache/camel/pull/12530
# Description
Draft code demonstrating a Vertx server handler implementation that manages server-side sessions and session cookie handling.
# Target
- [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20019: demo session handler implementation [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #12530:
URL: https://github.com/apache/camel/pull/12530#discussion_r1434395655
##########
components/camel-platform-http-vertx/pom.xml:
##########
@@ -84,6 +84,11 @@
<artifactId>camel-log</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-vertx-http</artifactId>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Yeah potentially - though it may be that camel-platform-http-vertx is built before all the vertx components where this one is from. But agree we had been bitten in the past with build cycles going full circle and breaking the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20019: demo session handler implementation [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12530:
URL: https://github.com/apache/camel/pull/12530#issuecomment-1866190831
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20019: demo session handler implementation [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on PR #12530:
URL: https://github.com/apache/camel/pull/12530#issuecomment-1866196304
Wondering whether this approach is what you're thinking in relation to this ticket, or whether you're hoping fore a more general cookie handler where cookies can be added/removed per route. The producer cookie handlers I found looked like they were for session handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20019: demo session handler implementation [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris merged PR #12530:
URL: https://github.com/apache/camel/pull/12530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20019: demo session handler implementation [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on code in PR #12530:
URL: https://github.com/apache/camel/pull/12530#discussion_r1435821352
##########
components/camel-platform-http-vertx/pom.xml:
##########
@@ -84,6 +84,11 @@
<artifactId>camel-log</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-vertx-http</artifactId>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Updated the test to use `camel-http` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20019: demo session handler implementation [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on code in PR #12530:
URL: https://github.com/apache/camel/pull/12530#discussion_r1436400648
##########
components/camel-platform-http-vertx/pom.xml:
##########
@@ -84,6 +84,11 @@
<artifactId>camel-log</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-vertx-http</artifactId>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Hey @orpiske, by using `camel-http` instead of `camel-vertx-http` it now means that no new deps have been introduced by this change. Would it be OK it we tackle the test dependency management improvements that you've proposed in a separate ticket/PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20019: demo session handler implementation [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #12530:
URL: https://github.com/apache/camel/pull/12530#discussion_r1436452004
##########
components/camel-platform-http-vertx/pom.xml:
##########
@@ -84,6 +84,11 @@
<artifactId>camel-log</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-vertx-http</artifactId>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Yes, that's OK to me. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20019: demo session handler implementation [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on code in PR #12530:
URL: https://github.com/apache/camel/pull/12530#discussion_r1435889952
##########
components/camel-platform-http-vertx/pom.xml:
##########
@@ -84,6 +84,11 @@
<artifactId>camel-log</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-vertx-http</artifactId>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Thanks for that, let me look into it.
Merry Christmas!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20019: demo session handler implementation [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #12530:
URL: https://github.com/apache/camel/pull/12530#discussion_r1434133814
##########
components/camel-platform-http-vertx/pom.xml:
##########
@@ -84,6 +84,11 @@
<artifactId>camel-log</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-vertx-http</artifactId>
+ <scope>test</scope>
+ </dependency>
Review Comment:
I'm a bit concerned that this may cause some weird cyclic dependency problems (or at least make the whole dependency chain more complex).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20019: demo session handler implementation [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #12530:
URL: https://github.com/apache/camel/pull/12530#discussion_r1435822406
##########
components/camel-platform-http-vertx/pom.xml:
##########
@@ -84,6 +84,11 @@
<artifactId>camel-log</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-vertx-http</artifactId>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Thanks, but that still may create a very complex dependency chain as you have components within `components` with dependencies among themselves.
The best way, I think, would be to create a `test-infra` module that is completely independent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org