[GitHub] [flink] dforciea commented on a change in pull request #13570: [FLINK-19522][Table SQL / Ecosystem] Add auto-commit option for Table/SQL API

[GitBox <gi...@apache.org>]

dforciea commented on a change in pull request #13570:
URL: https://github.com/apache/flink/pull/13570#discussion_r502797174



##########
File path: docs/dev/table/connectors/jdbc.md
##########
@@ -183,7 +183,14 @@ Connector Options
       <td style="word-wrap: break-word;">0</td>
       <td>Integer</td>
       <td>The number of rows that should be fetched from the database when reading per round trip. If the value specified is zero, then the hint is ignored.</td>
-    </tr>     
+    </tr>
+    <tr>
+      <td><h5>scan.auto-commit</h5></td>
+      <td>optional</td>
+      <td style="word-wrap: break-word;">(none)</td>
+      <td>Boolean</td>
+      <td>Sets the auto commit flag on the JDBC driver.</td>

Review comment:
       Good idea. I had actually at first made a comment about the postgres JDBC driver behavior with scans, since I have run across this multiple times, but had removed it since it was vendor-specific. Any thoughts about including a comment about that?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org