[jira] Resolved: (WSCOMMONS-317) Reverted code, need to review code

["Andreas Veithen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WSCOMMONS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen resolved WSCOMMONS-317.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: Axiom 1.2.8
         Assignee: Andreas Veithen  (was: Nandana Mihindukulasooriya)

A node should always be a child of its parent (if it has one). The change in r642096 broke this rule and it was correct to revert it. Therefore this issue should be considered as solved.

> Reverted code, need to review code
> ----------------------------------
>
>                 Key: WSCOMMONS-317
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-317
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Davanum Srinivas
>            Assignee: Andreas Veithen
>             Fix For: Axiom 1.2.8
>
>
> Nandana,
> In my svn commit:
> http://svn.apache.org/viewvc?rev=642246&view=rev
> I have reverted change you made in:
> http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ChildNode.java?r1=642096&r2=642095&pathrev=642096
> Which is part of:
> http://svn.apache.org/viewvc?view=rev&revision=642096
> As it breaks Axis2/SAAJ:
> ------------------------------------------------------------------------------
> Tests run: 24, Failures: 15, Errors: 9, Skipped: 0, Time elapsed: 0.072 sec <<< FAILURE!
> testAddDetailsTwice(org.apache.axis2.saaj.SOAPFaultTest)  Time elapsed: 0.006 sec  <<< ERROR!
> org.apache.axiom.om.OMException: Parent level elements cannot be detached
>         at org.apache.axiom.om.impl.dom.ChildNode.detach(ChildNode.java:116)
>         at org.apache.axiom.om.impl.dom.ElementImpl.discard(ElementImpl.java:1349)
>         at org.apache.axiom.soap.impl.dom.SOAPFaultImpl.setNewElement(SOAPFaultImpl.java:148)
>         at org.apache.axiom.soap.impl.dom.SOAPFaultImpl.setCode(SOAPFaultImpl.java:91)
>         at org.apache.axiom.soap.impl.dom.soap11.SOAP11FaultImpl.setCode(SOAP11FaultImpl.java:73)
>         at org.apache.axis2.saaj.SOAPFaultImpl.setFaultCode(SOAPFaultImpl.java:733)
>         at org.apache.axis2.saaj.SOAPFaultImpl.setDefaults(SOAPFaultImpl.java:77)
>         at org.apache.axis2.saaj.SOAPBodyImpl.addFault(SOAPBodyImpl.java:193)
>         at org.apache.axis2.saaj.SOAPFaultTest.testAddDetailsTwice(SOAPFaultTest.java:169)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:45)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:599)
>         at junit.framework.TestCase.runTest(TestCase.java:168)
>         at junit.framework.TestCase.runBare(TestCase.java:134)
>         at junit.framework.TestResult$1.protect(TestResult.java:110)
>         at junit.framework.TestResult.runProtected(TestResult.java:128)
>         at junit.framework.TestResult.run(TestResult.java:113)
>         at junit.framework.TestCase.run(TestCase.java:124)
>         at junit.framework.TestSuite.runTest(TestSuite.java:232)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.