You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "flowchartsman (via GitHub)" <gi...@apache.org> on 2023/05/27 02:34:50 UTC
[GitHub] [pulsar] flowchartsman opened a new pull request, #20413: [fix][fn] Go functions must retrieve consumers by non-particioned topic ID
flowchartsman opened a new pull request, #20413:
URL: https://github.com/apache/pulsar/pull/20413
Fixes #19367
### Modifications
Retrieve consumers from the index based off of non-partitioned topic name.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
**Note**: there is no e2e for Go pulsar functions. Verifying this change is a matter of not having panics when using pulsar functions with partitioned topics.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [X] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/flowchartsman/pulsar/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] flowchartsman commented on pull request #20413: [fix][fn] Go functions must retrieve consumers by non-particioned topic ID
Posted by "flowchartsman (via GitHub)" <gi...@apache.org>.
flowchartsman commented on PR #20413:
URL: https://github.com/apache/pulsar/pull/20413#issuecomment-1565173879
This PR supplants #19372, which has been sitting around long enough to become pretty out of date. To facilitate a faster merge, I'm submitting this variant now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #20413: [fix][fn] Go functions must retrieve consumers by non-particioned topic ID
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #20413:
URL: https://github.com/apache/pulsar/pull/20413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org