[jira] [Commented] (FLINK-3103) Remove synchronization in FsStateBackend#FsCheckpointStateOutputStream#close()

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066750#comment-15066750 ] 

ASF GitHub Bot commented on FLINK-3103:
---------------------------------------

GitHub user tedyu opened a pull request:

    https://github.com/apache/flink/pull/1474

    FLINK-3103 Remove synchronization in FsStateBackend#FsCheckpointStateOutputStream#close()

    Stephan made the following comment:
    
    I would actually suggest to not use a lock in the close() methods either. In a single threaded use, there is really no need for these locks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tedyu/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1474.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1474
    
----
commit eb6dd48ee8a9a20889d7fcd994b8fc0d7df9ba1c
Author: tedyu <yu...@gmail.com>
Date:   2015-12-21T17:29:16Z

    FLINK-3103 Remove synchronization in FsStateBackend#FsCheckpointStateOutputStream#close()

----


> Remove synchronization in FsStateBackend#FsCheckpointStateOutputStream#close()
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-3103
>                 URL: https://issues.apache.org/jira/browse/FLINK-3103
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>
> Here is related code:
> {code}
>     public void flush() throws IOException {
>       if (!closed) {
> {code}
> Lock "FsCheckpointStateOutputStream.this" should be held.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)