You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/06/02 07:00:03 UTC
[GitHub] spark pull request #21484: [WIP] Replace queryExecution by planWithBarrier i...
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/21484
[WIP] Replace queryExecution by planWithBarrier in toDF
## What changes were proposed in this pull request?
TODO
## How was this patch tested?
TODO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark toDF
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21484.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21484
----
commit cc6e83491bc596997a850a21b6f4870727da9594
Author: Xiao Li <ga...@...>
Date: 2018-06-02T06:58:56Z
fix.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21484: [WIP] Replace queryExecution by planWithBarrier in toDF
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21484
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3776/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21484: [WIP] Replace queryExecution by planWithBarrier in toDF
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21484
**[Test build #91414 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91414/testReport)** for PR 21484 at commit [`cc6e834`](https://github.com/apache/spark/commit/cc6e83491bc596997a850a21b6f4870727da9594).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21484: [WIP] Replace queryExecution by planWithBarrier in toDF
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21484
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91414/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21484: [WIP] Replace queryExecution by planWithBarrier in toDF
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21484
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21484: [WIP] Replace queryExecution by planWithBarrier i...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/21484
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21484: [WIP] Replace queryExecution by planWithBarrier i...
Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21484#discussion_r192564074
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -390,7 +390,7 @@ class Dataset[T] private[sql](
*/
// This is declared with parentheses to prevent the Scala compiler from treating
// `ds.toDF("1")` as invoking this toDF and then apply on the returned DataFrame.
- def toDF(): DataFrame = new Dataset[Row](sparkSession, queryExecution, RowEncoder(schema))
+ def toDF(): DataFrame = new Dataset[Row](sparkSession, planWithBarrier, RowEncoder(schema))
--- End diff --
This will probably create a huge regression if you rerun the `DataFrame`. SparkPlans cache shuffle RDDs and we reuse previously executed shuffles when you re-run the frame.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21484: [WIP] Replace queryExecution by planWithBarrier in toDF
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21484
**[Test build #91414 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91414/testReport)** for PR 21484 at commit [`cc6e834`](https://github.com/apache/spark/commit/cc6e83491bc596997a850a21b6f4870727da9594).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21484: [WIP] Replace queryExecution by planWithBarrier in toDF
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21484
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org