You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by " Kaige Liu (JIRA)" <ji...@apache.org> on 2018/01/26 07:29:00 UTC
[jira] [Commented] (KYLIN-2893) Missing zero check for
totalHitFrequency in CuboidStats ctor
[ https://issues.apache.org/jira/browse/KYLIN-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340650#comment-16340650 ]
Kaige Liu commented on KYLIN-2893:
-----------------------------------
Hi [~lidong_sjtu], would you please help review my patch. Thanks.
> Missing zero check for totalHitFrequency in CuboidStats ctor
> ------------------------------------------------------------
>
> Key: KYLIN-2893
> URL: https://issues.apache.org/jira/browse/KYLIN-2893
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Kaige Liu
> Priority: Minor
> Attachments: KYLIN-2893.master.001.patch
>
>
> {code}
> if (hitFrequencyMap.get(cuboid) != null) {
> tmpCuboidHitProbabilityMap.put(cuboid, unitUncertainProb
> + (1 - WEIGHT_FOR_UN_QUERY) * hitFrequencyMap.get(cuboid) / totalHitFrequency);
> {code}
> We should check that totalHitFrequency is not zero before performing division.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)