[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1661: MINIFICPP-2196 Integrate cppcoreguideline clang-tidy checks in CI

["lordgamez (via GitHub)" <gi...@apache.org>]

lordgamez commented on code in PR #1661:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1661#discussion_r1335470315


##########
libminifi/src/utils/BackTrace.cpp:
##########
@@ -42,10 +42,9 @@ namespace {
    */
   optional<std::string> demangle_symbol(const char* symbol_name) {
     int status;
-    char* demangled = abi::__cxa_demangle(symbol_name, nullptr, nullptr, &status);
+    std::unique_ptr<char> demangled(abi::__cxa_demangle(symbol_name, nullptr, nullptr, &status));

Review Comment:
   Updated in 56ad23b1bafb764f8bf4e6e66b71af3641fea87d



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org