You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2018/02/17 00:27:09 UTC
Review Request 65696: Allowed base64-decoding with whitespaces.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65696/
-----------------------------------------------------------
Review request for mesos, Michael Park and Till Toenshoff.
Bugs: MESOS-8569
https://issues.apache.org/jira/browse/MESOS-8569
Repository: mesos
Description
-------
Most base64 decoders do not fail on encountering whitespace characters
as several encoders embed newlines to enforce line-width in encoded
data.
Diffs
-----
3rdparty/stout/include/stout/base64.hpp eabc9b0f0ad794ffccda44e338ea855b8c4a796f
3rdparty/stout/tests/base64_tests.cpp a6837c820384e3311d2c030885039a7dd7f01a66
Diff: https://reviews.apache.org/r/65696/diff/1/
Testing
-------
Updated base64 tests and ran make check
Thanks,
Kapil Arya
Re: Review Request 65696: Allowed base64-decoding with whitespaces.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65696/#review197705
-----------------------------------------------------------
PASS: Mesos patch 65696 was successfully built and tested.
Reviews applied: `['65696']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65696
- Mesos Reviewbot Windows
On Feb. 17, 2018, 8:27 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65696/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2018, 8:27 a.m.)
>
>
> Review request for mesos, Michael Park and Till Toenshoff.
>
>
> Bugs: MESOS-8569
> https://issues.apache.org/jira/browse/MESOS-8569
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Most base64 decoders do not fail on encountering whitespace characters
> as several encoders embed newlines to enforce line-width in encoded
> data.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/base64.hpp eabc9b0f0ad794ffccda44e338ea855b8c4a796f
> 3rdparty/stout/tests/base64_tests.cpp a6837c820384e3311d2c030885039a7dd7f01a66
>
>
> Diff: https://reviews.apache.org/r/65696/diff/1/
>
>
> Testing
> -------
>
> Updated base64 tests and ran make check
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 65696: Allowed base64-decoding with whitespaces.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65696/#review197813
-----------------------------------------------------------
PASS: Mesos patch 65696 was successfully built and tested.
Reviews applied: `['65696']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65696
- Mesos Reviewbot Windows
On Feb. 17, 2018, 12:27 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65696/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2018, 12:27 a.m.)
>
>
> Review request for mesos, Michael Park and Till Toenshoff.
>
>
> Bugs: MESOS-8569
> https://issues.apache.org/jira/browse/MESOS-8569
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Most base64 decoders do not fail on encountering whitespace characters
> as several encoders embed newlines to enforce line-width in encoded
> data.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/base64.hpp eabc9b0f0ad794ffccda44e338ea855b8c4a796f
> 3rdparty/stout/tests/base64_tests.cpp a6837c820384e3311d2c030885039a7dd7f01a66
>
>
> Diff: https://reviews.apache.org/r/65696/diff/4/
>
>
> Testing
> -------
>
> Updated base64 tests and ran make check
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 65696: Allowed base64-decoding with whitespaces.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65696/#review197809
-----------------------------------------------------------
Ship it!
3rdparty/stout/include/stout/base64.hpp
Line 92 (original), 92 (patched)
<https://reviews.apache.org/r/65696/#comment278087>
Can we add a leading comment on which exact variants of the most recent RFC we now support with all of our options here? Maybe reference the whitespace handling advices from the RFC to make sure people can validate - either comment or commit description.
- Till Toenshoff
On Feb. 17, 2018, 12:27 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65696/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2018, 12:27 a.m.)
>
>
> Review request for mesos, Michael Park and Till Toenshoff.
>
>
> Bugs: MESOS-8569
> https://issues.apache.org/jira/browse/MESOS-8569
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Most base64 decoders do not fail on encountering whitespace characters
> as several encoders embed newlines to enforce line-width in encoded
> data.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/base64.hpp eabc9b0f0ad794ffccda44e338ea855b8c4a796f
> 3rdparty/stout/tests/base64_tests.cpp a6837c820384e3311d2c030885039a7dd7f01a66
>
>
> Diff: https://reviews.apache.org/r/65696/diff/3/
>
>
> Testing
> -------
>
> Updated base64 tests and ran make check
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 65696: Allowed base64-decoding with whitespaces.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65696/#review197712
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65696]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 17, 2018, 8:27 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65696/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2018, 8:27 a.m.)
>
>
> Review request for mesos, Michael Park and Till Toenshoff.
>
>
> Bugs: MESOS-8569
> https://issues.apache.org/jira/browse/MESOS-8569
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Most base64 decoders do not fail on encountering whitespace characters
> as several encoders embed newlines to enforce line-width in encoded
> data.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/base64.hpp eabc9b0f0ad794ffccda44e338ea855b8c4a796f
> 3rdparty/stout/tests/base64_tests.cpp a6837c820384e3311d2c030885039a7dd7f01a66
>
>
> Diff: https://reviews.apache.org/r/65696/diff/1/
>
>
> Testing
> -------
>
> Updated base64 tests and ran make check
>
>
> Thanks,
>
> Kapil Arya
>
>