You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by "J.Pietschmann" <j3...@yahoo.de> on 2005/08/14 01:17:04 UTC

ContentLayoutManager.getUserAgent

Hi devs,
javadoc complains for ContentLayoutManager.getUserAgent
that it cant find the reference to LayoutManager#getUserAgent
There aren't all that many references to a getUserAgent method
left in the layoutmanaget package and its subpackages.
Is this a left-over from earlier refactorings?

J.Pietschmann

Re: ContentLayoutManager.getUserAgent

Posted by Jeremias Maerki <de...@greenmail.ch>.
Well, after the necessary checks that they are really not used anymore.
Especially the layoutmgr package still contains several blocks of code
which are not in use anymore. They haven't all been removed, yet. At
least the more stable LMs can now be cleaned up. Eclipse is your friend
here. And if something might have been removed prematurely, SVN is an
even better friend. But let's hope that's not necessary.

On 14.08.2005 19:44:48 J.Pietschmann wrote:
> Jeremias Maerki wrote:
> > Yep:
> ...
> > I'm pretty sure you'll find more of these.
> 
> Does this mean the methods and associated fields can be safely
> removed?
> 
> J.Pietschmann



Jeremias Maerki


Re: ContentLayoutManager.getUserAgent

Posted by "J.Pietschmann" <j3...@yahoo.de>.
Jeremias Maerki wrote:
> Yep:
...
> I'm pretty sure you'll find more of these.

Does this mean the methods and associated fields can be safely
removed?

J.Pietschmann


Re: ContentLayoutManager.getUserAgent

Posted by Jeremias Maerki <de...@greenmail.ch>.
Yep:

http://svn.apache.org/viewcvs.cgi/xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/LayoutManager.java?rev=197701&r1=197605&r2=197701&diff_format=h

I'm pretty sure you'll find more of these.

On 14.08.2005 01:17:04 J.Pietschmann wrote:
> Hi devs,
> javadoc complains for ContentLayoutManager.getUserAgent
> that it cant find the reference to LayoutManager#getUserAgent
> There aren't all that many references to a getUserAgent method
> left in the layoutmanaget package and its subpackages.
> Is this a left-over from earlier refactorings?
> 
> J.Pietschmann



Jeremias Maerki