You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/22 09:58:17 UTC

[GitHub] [airflow] eladkal commented on a change in pull request #14344: Fix Incorrect warning in upgrade check and error in reading file

eladkal commented on a change in pull request #14344:
URL: https://github.com/apache/airflow/pull/14344#discussion_r580118168



##########
File path: airflow/upgrade/rules/chain_between_dag_and_operator_not_allowed_rule.py
##########
@@ -36,7 +36,7 @@ def _change_info(self, file_path, line_number):
 
     def _check_file(self, file_path):
         problems = []
-        with open(file_path, "r") as file_pointer:
+        with open(file_path, "r", errors="ignore") as file_pointer:

Review comment:
       Do you need also a "Unable to read python file" message like added in https://github.com/apache/airflow/pull/13371 ? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org