You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "unknowntpo (via GitHub)" <gi...@apache.org> on 2024/10/14 22:58:02 UTC
[PR] KAKFA-17173: move quota config params from KafkaConfig to QuotaConfig [kafka]
unknowntpo opened a new pull request, #17505:
URL: https://github.com/apache/kafka/pull/17505
This PR rename `QuotaConfigs` to `QuotaConfig`, and
move quota config related val from `KafkaConfig` to `QuotaConfig`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAKFA-17173: move quota config params from KafkaConfig to QuotaConfig [kafka]
Posted by "unknowntpo (via GitHub)" <gi...@apache.org>.
unknowntpo commented on PR #17505:
URL: https://github.com/apache/kafka/pull/17505#issuecomment-2412606542
@chia7712 Would you like to review this PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAKFA-17173: move quota config params from KafkaConfig to QuotaConfig [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #17505:
URL: https://github.com/apache/kafka/pull/17505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAKFA-17173: move quota config params from KafkaConfig to QuotaConfig [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on code in PR #17505:
URL: https://github.com/apache/kafka/pull/17505#discussion_r1802179319
##########
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##########
@@ -1409,8 +1409,8 @@ static ReassignPartitionsCommandOptions validateAndParseArgs(String[] args) {
}
OptionSpec<?> action = allActions.get(0);
-
- if (opts.options.has(opts.bootstrapServerOpt) && opts.options.has(opts.bootstrapControllerOpt))
+
+ if (opts.options.has(opts.bootstrapServerOpt) && opts.options.has(opts.bootstrapControllerOpt))
Review Comment:
Please revert this unnessary change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAKFA-17173: move quota config params from KafkaConfig to QuotaConfig [kafka]
Posted by "unknowntpo (via GitHub)" <gi...@apache.org>.
unknowntpo commented on code in PR #17505:
URL: https://github.com/apache/kafka/pull/17505#discussion_r1805549403
##########
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##########
@@ -1409,8 +1409,8 @@ static ReassignPartitionsCommandOptions validateAndParseArgs(String[] args) {
}
OptionSpec<?> action = allActions.get(0);
-
- if (opts.options.has(opts.bootstrapServerOpt) && opts.options.has(opts.bootstrapControllerOpt))
+
+ if (opts.options.has(opts.bootstrapServerOpt) && opts.options.has(opts.bootstrapControllerOpt))
Review Comment:
@m1a2st Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org