You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/10/14 07:37:30 UTC

[GitHub] [carbondata] QiangCai commented on a change in pull request #3950: [CARBONDATA-3889] Enable scalastyle check for all scala test code

QiangCai commented on a change in pull request #3950:
URL: https://github.com/apache/carbondata/pull/3950#discussion_r504464144



##########
File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/mergedata/CarbonDataFileMergeTestCaseOnSI.scala
##########
@@ -14,20 +14,22 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+

Review comment:
       reverted

##########
File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestAlterTableColumnRenameWithIndex.scala
##########
@@ -73,9 +73,12 @@ class TestAlterTableColumnRenameWithIndex extends QueryTest with BeforeAndAfterA
     sql("alter table si_rename change c test string")
     sql("alter table si_rename change d testSI string")
     sql("show indexes on si_rename").collect
-    val query2 = sql("select test,testsi from si_rename where testsi = 'pqr' or test = 'def'").count()
+    val query2 = sql("select test,testsi from si_rename where testsi = 'pqr' or test = 'def'")
+      .count()
     assert(query1 == query2)
-    val df = sql("select test,testsi from si_rename where testsi = 'pqr' or test = 'def'").queryExecution.sparkPlan
+    val df = sql("select test,testsi from si_rename where testsi = 'pqr' or test = 'def'")
+      .queryExecution

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org