You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2017/05/03 09:12:49 UTC

Review Request 58948: LENS-1416 : Union query order by should work on column alias

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58948/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-1416
    https://issues.apache.org/jira/browse/LENS-1416


Repository: lens


Description
-------

In union queries order by clause should have column alias instead of column.


Diffs
-----

  lens-api/src/main/resources/lens-errors.conf e5536bb 
  lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java babe3de 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 467ca0a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java f5f468f 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 1b4cc10 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java 8e65139 


Diff: https://reviews.apache.org/r/58948/diff/1/


Testing
-------


Thanks,

Sushil Mohanty


Re: Review Request 58948: LENS-1416 : Union query order by should work on column alias

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58948/#review173711
-----------------------------------------------------------


Ship it!




Ship It!

- Amareshwari Sriramadasu


On May 3, 2017, 9:12 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58948/
> -----------------------------------------------------------
> 
> (Updated May 3, 2017, 9:12 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1416
>     https://issues.apache.org/jira/browse/LENS-1416
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> In union queries order by clause should have column alias instead of column.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/lens-errors.conf e5536bb 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java babe3de 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 467ca0a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java f5f468f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 1b4cc10 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java 8e65139 
> 
> 
> Diff: https://reviews.apache.org/r/58948/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>