[spark] branch master updated: [SPARK-37677][CORE] Unzip could keep file permissions

[gu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 4e01ebe60cc [SPARK-37677][CORE] Unzip could keep file permissions
4e01ebe60cc is described below

commit 4e01ebe60cc1a909a3492c10262231c6a086b867
Author: jokercurry <98...@qq.com>
AuthorDate: Tue Mar 28 14:26:39 2023 +0900

    [SPARK-37677][CORE] Unzip could keep file permissions
    
    ### What changes were proposed in this pull request?
    
    Just remove comment.
    
    ### Why are the changes needed?
    
    After https://github.com/apache/hadoop/pull/4036, unzip could unzip could keep file permissions.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    No need, has been added in hadoop-client side.
    
    Closes #40572 from smallzhongfeng/SPARK-37677.
    
    Authored-by: jokercurry <98...@qq.com>
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
 core/src/main/scala/org/apache/spark/util/Utils.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/src/main/scala/org/apache/spark/util/Utils.scala b/core/src/main/scala/org/apache/spark/util/Utils.scala
index d81e85ffe08..a6a1f7d7b1e 100644
--- a/core/src/main/scala/org/apache/spark/util/Utils.scala
+++ b/core/src/main/scala/org/apache/spark/util/Utils.scala
@@ -589,7 +589,7 @@ private[spark] object Utils extends Logging {
     if (lowerSrc.endsWith(".jar")) {
       RunJar.unJar(source, dest, RunJar.MATCH_ANY)
     } else if (lowerSrc.endsWith(".zip")) {
-      // TODO(SPARK-37677): should keep file permissions. Java implementation doesn't.
+      // After issue HADOOP-18145, unzip could keep file permissions.
       FileUtil.unZip(source, dest)
     } else if (lowerSrc.endsWith(".tar.gz") || lowerSrc.endsWith(".tgz")) {
       FileUtil.unTar(source, dest)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org