You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/12/16 03:16:24 UTC

[GitHub] [kylin] zzcclp commented on a change in pull request #1512: KYLIN-4842 Supports grouping sets function for Kylin 4

zzcclp commented on a change in pull request #1512:
URL: https://github.com/apache/kylin/pull/1512#discussion_r543876574



##########
File path: kylin-spark-project/kylin-spark-common/src/test/java/org/apache/spark/sql/common/SparkQueryTest.scala
##########
@@ -116,9 +116,9 @@ object SparkQueryTest {
                    |== Results ==
                    |${
                     sideBySide(
-                        s"== Kylin Answer - ${kylinAnswer.size} ==" +:
+                        s"== Expected Answer - ${kylinAnswer.size} ==" +:

Review comment:
       yes, it's correct, the 'sparkResults' is the results querying from sparder, and 'kylinResults' is the expected results.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org