[jira] [Commented] (PIG-3829) Make custom counter work

["Cheolsoo Park (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944661#comment-13944661 ] 

Cheolsoo Park commented on PIG-3829:
------------------------------------

[~daijy], thank you for taking care of this. I have 2 minor comments.

# These methods seem not relevant since you're not implementing Progressable. Can you delete them?
{code:title=TezStatusReporter.java}
+    public void progress() {
+        if (context != null) {
+            context.setProgress(0);
+        }
+    }
+
+    public float getProgress() {
+        return 0;
+    }
{code}
# Can you update the comment accordingly?
{code:title=PigTezLogger.java}
+                //TODO:
+                //in local mode of execution if the PigHadoopLogger is used initially,
+                //then aggregation cannot be performed as the reporter will be null.
+                //The reference to a reporter is given by Hadoop at run time.
+                //In local mode, due to the absence of Hadoop there will be no reporter
+                //Just print the warning message as is.
+                //If a warning message is printed in map reduce mode when aggregation
+                //is turned on then we have a problem, its a bug.
{code}
Otherwise looks good to me.

> Make custom counter work
> ------------------------
>
>                 Key: PIG-3829
>                 URL: https://issues.apache.org/jira/browse/PIG-3829
>             Project: Pig
>          Issue Type: Sub-task
>          Components: tez
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: tez-branch
>
>         Attachments: PIG-3829-1.patch
>
>
> Make custom Pig counters defined in PigWarning/PigCounters work. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)