You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2015/09/18 21:49:07 UTC

Review Request 38507: SQOOP-2582 Query import won't work for parquet

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38507/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2294
    https://issues.apache.org/jira/browse/SQOOP-2294


Repository: sqoop-trunk


Description
-------

I've altereted the inserted code to be run only for table import. This is fine because the fix from SQOOP-2294 is relevant only for table imports.


Diffs
-----

  src/java/org/apache/sqoop/tool/CodeGenTool.java 22ab030 
  src/test/com/cloudera/sqoop/TestParquetImport.java ae2e617 

Diff: https://reviews.apache.org/r/38507/diff/


Testing
-------

I've added query based unit test for parquet, so that this won't happen in the future.


Thanks,

Jarek Cecho


Re: Review Request 38507: SQOOP-2582 Query import won't work for parquet

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38507/
-----------------------------------------------------------

(Updated Sept. 18, 2015, 7:49 p.m.)


Review request for Sqoop.


Bugs: SQOOP-2582
    https://issues.apache.org/jira/browse/SQOOP-2582


Repository: sqoop-trunk


Description
-------

I've altereted the inserted code to be run only for table import. This is fine because the fix from SQOOP-2294 is relevant only for table imports.


Diffs
-----

  src/java/org/apache/sqoop/tool/CodeGenTool.java 22ab030 
  src/test/com/cloudera/sqoop/TestParquetImport.java ae2e617 

Diff: https://reviews.apache.org/r/38507/diff/


Testing
-------

I've added query based unit test for parquet, so that this won't happen in the future.


Thanks,

Jarek Cecho