You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/27 14:21:11 UTC
[GitHub] [arrow-cookbook] amol- opened a new pull request #51: Creating tables recipe
amol- opened a new pull request #51:
URL: https://github.com/apache/arrow-cookbook/pull/51
https://issues.apache.org/jira/browse/ARROW-13715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] jorisvandenbossche commented on a change in pull request #51: Creating tables recipe
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #51:
URL: https://github.com/apache/arrow-cookbook/pull/51#discussion_r698306893
##########
File path: python/source/create.rst
##########
@@ -7,6 +7,32 @@ Tensors and all other Arrow entities.
.. contents::
+Creating Tables
+===============
+
+Arrow supports tabular data in :class:`pyarrow.Table`, each column
+is represented by a :class:`pyarrow.Array` and tables can be created
+by pairing multiple arrays with names for their columns
+
+.. testcode::
+
+ import pyarrow as pa
+
+ table = pa.table([
+ pa.array([1, 2, 3, 4, 5]),
Review comment:
Small nitpick, but use standard 4-space indentation here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] pitrou merged pull request #51: Creating tables recipe
Posted by GitBox <gi...@apache.org>.
pitrou merged pull request #51:
URL: https://github.com/apache/arrow-cookbook/pull/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] amol- commented on a change in pull request #51: Creating tables recipe
Posted by GitBox <gi...@apache.org>.
amol- commented on a change in pull request #51:
URL: https://github.com/apache/arrow-cookbook/pull/51#discussion_r698365277
##########
File path: python/source/create.rst
##########
@@ -7,6 +7,32 @@ Tensors and all other Arrow entities.
.. contents::
+Creating Tables
+===============
+
+Arrow supports tabular data in :class:`pyarrow.Table`, each column
+is represented by a :class:`pyarrow.Array` and tables can be created
+by pairing multiple arrays with names for their columns
+
+.. testcode::
+
+ import pyarrow as pa
+
+ table = pa.table([
+ pa.array([1, 2, 3, 4, 5]),
Review comment:
addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] amol- commented on a change in pull request #51: Creating tables recipe
Posted by GitBox <gi...@apache.org>.
amol- commented on a change in pull request #51:
URL: https://github.com/apache/arrow-cookbook/pull/51#discussion_r700209826
##########
File path: python/source/create.rst
##########
@@ -7,6 +7,32 @@ Tensors and all other Arrow entities.
.. contents::
+Creating Tables
+===============
+
+Arrow supports tabular data in :class:`pyarrow.Table`: each column
+is represented by a :class:`pyarrow.Array` and tables can be created
Review comment:
:+1: replaced `Array` with `ChunkedArray`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] amol- commented on pull request #51: Creating tables recipe
Posted by GitBox <gi...@apache.org>.
amol- commented on pull request #51:
URL: https://github.com/apache/arrow-cookbook/pull/51#issuecomment-908222024
I integrated suggestions, so this should now be good to go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] jorisvandenbossche commented on a change in pull request #51: Creating tables recipe
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #51:
URL: https://github.com/apache/arrow-cookbook/pull/51#discussion_r698306350
##########
File path: python/source/create.rst
##########
@@ -7,6 +7,32 @@ Tensors and all other Arrow entities.
.. contents::
+Creating Tables
+===============
+
+Arrow supports tabular data in :class:`pyarrow.Table`, each column
Review comment:
```suggestion
Arrow supports tabular data in :class:`pyarrow.Table`: each column
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] pitrou commented on a change in pull request #51: Creating tables recipe
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #51:
URL: https://github.com/apache/arrow-cookbook/pull/51#discussion_r700129219
##########
File path: python/source/create.rst
##########
@@ -7,6 +7,32 @@ Tensors and all other Arrow entities.
.. contents::
+Creating Tables
+===============
+
+Arrow supports tabular data in :class:`pyarrow.Table`: each column
+is represented by a :class:`pyarrow.Array` and tables can be created
Review comment:
Internally, each column is a chunked array. But (non-chunked) arrays are also supported for constructing tables, for convenience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] amol- commented on pull request #51: Creating tables recipe
Posted by GitBox <gi...@apache.org>.
amol- commented on pull request #51:
URL: https://github.com/apache/arrow-cookbook/pull/51#issuecomment-908158567
In the Python cookbook at the moment no subheadings were used, all recipes within a chapter were at the same level. We might consider adding further grouping but I think that should be done for all sections, not just this one, and I fear it might add confusion as we might end up with many subgroups of just two entries each.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org