You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/24 22:44:06 UTC

[GitHub] [helix] alirezazamani commented on pull request #1390: Include pending messages in getCurrentInstanceToTaskAssignments method

alirezazamani commented on pull request #1390:
URL: https://github.com/apache/helix/pull/1390#issuecomment-698625813


   > LGTM! 2 minor questions.
   > 
   > 1. I remember there are 1200 or more tests. But it is 1199 in your result. Did we remove one?
   > 2. Please follow the PR template and note the new test case that you added to the description of PR.
   
   1- Rebased and ran the tests again and updated the test results.
   2- Done.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org