You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by davidtzoor <gi...@git.apache.org> on 2016/06/18 12:00:37 UTC
[GitHub] zeppelin pull request #1044: Add force layout visualization in paragraphs fo...
GitHub user davidtzoor opened a pull request:
https://github.com/apache/zeppelin/pull/1044
Add force layout visualization in paragraphs for SQL queries
### What is this PR for?
Add force layout (graph) visualization to the existing set of visualizations in Zeppelin Web notp.
### What type of PR is it?
[Feature]
### What is the Jira issue?
[ZEPPELIN-1011]
### How should this be tested?
The testes are incorporated within the existing test suite.
### Screenshot
### Questions:
* Does the licenses files need update?
No.
* Is there breaking changes for older versions?
No.
* Does this needs documentation?
We can add some documentation explaining about the different fields that need to be selected in order to generate the force layout component.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davidtzoor/zeppelin forcelayout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1044.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1044
----
commit ac546b24cc5ff1d52923b9e1e6e61050137328c9
Author: David Tzoor <dt...@paypal.com>
Date: 2016-06-18T11:47:28Z
add force layout button
commit 964cba722edd98cec2867ab6bf2171a03d2acbec
Author: David Tzoor <dt...@paypal.com>
Date: 2016-06-18T11:48:03Z
add div and svg tags that will contain the force layout object
commit 2f53e1947a8ff17f17eb36907424f60a722a3318
Author: David Tzoor <dt...@paypal.com>
Date: 2016-06-18T11:48:32Z
add column drop boxes for column selection for source and destination nodes
commit 9f8b6e65f0b23fe8fc9d090f0c5be90544cf8524
Author: David Tzoor <dt...@paypal.com>
Date: 2016-06-18T11:48:52Z
add force layout rendering and column selection handling methods
commit 9f1cea9800f06c6244335f9c9f3a5d601870b890
Author: David Tzoor <dt...@paypal.com>
Date: 2016-06-18T11:49:14Z
add CSS for force layout and tooltip
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1044: Add force layout visualization in paragraphs for SQL q...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor commented on the issue:
https://github.com/apache/zeppelin/pull/1044
@corneadoug do you want me to rebase to the master on my fork?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1044: Add force layout visualization in paragraphs for SQL q...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor commented on the issue:
https://github.com/apache/zeppelin/pull/1044
@AhyoungRyu I created a new PR (#1135) and closing this one. I hope this time it will work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1044: Add force layout visualization in paragraphs for SQL q...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1044
@davidtzoor Never mind. Please feel free to do that :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1044: Add force layout visualization in paragraphs for SQL q...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1044
@davidtzoor I'm not sure what you missed, your local master branch seems quite outdated. Zeppelin follows [fork & pull](https://github.com/apache/zeppelin/blob/master/CONTRIBUTING.md#source-control-workflow) model as a source control workflow.
##### 1. In your forked local repository
```
git checkout master
```
##### 2. set upstream and update local master
```
git remote add upstream git://github.com/apache/zeppelin.git
git fetch upstream
git pull upstream master
```
##### 3. rebase your branch `forcelayout` with latest master
```
git checkout forcelayout
git rebase master
```
Did you do as the above steps?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1044: Add force layout visualization in paragraphs for SQL q...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor commented on the issue:
https://github.com/apache/zeppelin/pull/1044
@corneadoug Have you seen this new PR? let me know if everything's good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1044: Add force layout visualization in paragraphs for SQL q...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1044
RIght, in you fork you need to pull the master from apache git and then rebase this branch on top of it, resolving the conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1044: Add force layout visualization in paragraphs for SQL q...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1044
@davidtzoor Can you rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1044: Add force layout visualization in paragraphs for SQL q...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor commented on the issue:
https://github.com/apache/zeppelin/pull/1044
@bzz I fixed the conflict
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1044: Add force layout visualization in paragraphs fo...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor closed the pull request at:
https://github.com/apache/zeppelin/pull/1044
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1044: Add force layout visualization in paragraphs for SQL q...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor commented on the issue:
https://github.com/apache/zeppelin/pull/1044
Hi @bzz, is there is issue with my PR? Please let me know if there is something I can do to help get it done. Thanks :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1044: Add force layout visualization in paragraphs for SQL q...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor commented on the issue:
https://github.com/apache/zeppelin/pull/1044
I am closing this PR and creating a new one (again). sorry for all the mess
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1044: Add force layout visualization in paragraphs for SQL q...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1044
@davidtzoor It seems many unrelated commits are included in this PR after you rebased. Could you check again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1044: Add force layout visualization in paragraphs for SQL q...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor commented on the issue:
https://github.com/apache/zeppelin/pull/1044
I think these are all the PR that were accepted since my initial pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1044: Add force layout visualization in paragraphs for SQL q...
Posted by davidtzoor <gi...@git.apache.org>.
Github user davidtzoor commented on the issue:
https://github.com/apache/zeppelin/pull/1044
@AhyoungRyu I just did a pull from the zeppelin repo to my fork, rebase and resolved the conflicts.
What did I do wrong?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1044: Add force layout visualization in paragraphs for SQL q...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1044
@davidtzoor Right, there has been some changes that brings conflicts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---