You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/28 09:39:20 UTC
[GitHub] [spark] xuanyuanking opened a new pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
xuanyuanking opened a new pull request #28390:
URL: https://github.com/apache/spark/pull/28390
### What changes were proposed in this pull request?
- Rephrase the API doc for `Column.as`
- Simplify the UTs
### Why are the changes needed?
Address comments in #28069
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
New UT added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-620684515
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-620496687
cc @cloud-fan @dongjoon-hyun @HeartSaVioR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621638010
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621407004
**[Test build #122067 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122067/testReport)** for PR 28390 at commit [`1101d05`](https://github.com/apache/spark/commit/1101d05c63d844ce8e99aa55e7ef5d02e4d5f3e1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621633513
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621554782
**[Test build #122098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122098/testReport)** for PR 28390 at commit [`d9baf7a`](https://github.com/apache/spark/commit/d9baf7a9c41f107003caffb543874e1ce66a1b39).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-620683132
**[Test build #121987 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121987/testReport)** for PR 28390 at commit [`6e98444`](https://github.com/apache/spark/commit/6e9844421a172d31bea4d28a8f5c9a8cd761c436).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621632823
**[Test build #122098 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122098/testReport)** for PR 28390 at commit [`d9baf7a`](https://github.com/apache/spark/commit/d9baf7a9c41f107003caffb543874e1ce66a1b39).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621240024
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621554782
**[Test build #122098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122098/testReport)** for PR 28390 at commit [`d9baf7a`](https://github.com/apache/spark/commit/d9baf7a9c41f107003caffb543874e1ce66a1b39).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-623202015
Thank you all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28390:
URL: https://github.com/apache/spark/pull/28390#discussion_r417464768
##########
File path: docs/sql-migration-guide.md
##########
@@ -28,6 +28,8 @@ license: |
- In Spark 3.1, SQL UI data adopts the `formatted` mode for the query plan explain results. To restore the behavior before Spark 3.0, you can set `spark.sql.ui.explainMode` to `extended`.
+ - In Spark 3.1, the column metadata will always be propagated in the API `name` and `as`. In Spark version 3.0 and earlier, the metadata of `NamedExpression` is set as the `explicitMetadata` for the new column. To restore the behavior before Spark 3.0, you can use the API `as(alias: String, metadata: Metadata)` with explicit metadata.
Review comment:
in the API `name` and `as` -> in the API `Column#name` and `Column#as`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-620684515
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621555225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on a change in pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on a change in pull request #28390:
URL: https://github.com/apache/spark/pull/28390#discussion_r417699463
##########
File path: docs/sql-migration-guide.md
##########
@@ -28,6 +28,8 @@ license: |
- In Spark 3.1, SQL UI data adopts the `formatted` mode for the query plan explain results. To restore the behavior before Spark 3.0, you can set `spark.sql.ui.explainMode` to `extended`.
+ - In Spark 3.1, the column metadata will always be propagated in the API `name` and `as`. In Spark version 3.0 and earlier, the metadata of `NamedExpression` is set as the `explicitMetadata` for the new column. To restore the behavior before Spark 3.0, you can use the API `as(alias: String, metadata: Metadata)` with explicit metadata.
Review comment:
Thanks, let me emphasize the usage of explicitMetadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28390:
URL: https://github.com/apache/spark/pull/28390#discussion_r417466050
##########
File path: docs/sql-migration-guide.md
##########
@@ -28,6 +28,8 @@ license: |
- In Spark 3.1, SQL UI data adopts the `formatted` mode for the query plan explain results. To restore the behavior before Spark 3.0, you can set `spark.sql.ui.explainMode` to `extended`.
+ - In Spark 3.1, the column metadata will always be propagated in the API `name` and `as`. In Spark version 3.0 and earlier, the metadata of `NamedExpression` is set as the `explicitMetadata` for the new column. To restore the behavior before Spark 3.0, you can use the API `as(alias: String, metadata: Metadata)` with explicit metadata.
Review comment:
> In Spark version 3.0 and earlier, the metadata of `NamedExpression` is set as the `explicitMetadata` for the new column.
I think the old behavior is using the metadata of `NamedExpression` at the time the API was called. The metadata won't change even if the underlying `NamedExpression` changes metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621238887
**[Test build #122067 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122067/testReport)** for PR 28390 at commit [`1101d05`](https://github.com/apache/spark/commit/1101d05c63d844ce8e99aa55e7ef5d02e4d5f3e1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-620499465
**[Test build #121987 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121987/testReport)** for PR 28390 at commit [`6e98444`](https://github.com/apache/spark/commit/6e9844421a172d31bea4d28a8f5c9a8cd761c436).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28390:
URL: https://github.com/apache/spark/pull/28390#discussion_r417464454
##########
File path: docs/sql-migration-guide.md
##########
@@ -28,6 +28,8 @@ license: |
- In Spark 3.1, SQL UI data adopts the `formatted` mode for the query plan explain results. To restore the behavior before Spark 3.0, you can set `spark.sql.ui.explainMode` to `extended`.
+ - In Spark 3.1, the column metadata will always be propagated in the API `name` and `as`. In Spark version 3.0 and earlier, the metadata of `NamedExpression` is set as the `explicitMetadata` for the new column. To restore the behavior before Spark 3.0, you can use the API `as(alias: String, metadata: Metadata)` with explicit metadata.
Review comment:
I think the patch has been merged to 3.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621408536
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621555225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-620499465
**[Test build #121987 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121987/testReport)** for PR 28390 at commit [`6e98444`](https://github.com/apache/spark/commit/6e9844421a172d31bea4d28a8f5c9a8cd761c436).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621240024
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621633513
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-620496314
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-620496314
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621238887
**[Test build #122067 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122067/testReport)** for PR 28390 at commit [`1101d05`](https://github.com/apache/spark/commit/1101d05c63d844ce8e99aa55e7ef5d02e4d5f3e1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621653199
Thanks for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28390:
URL: https://github.com/apache/spark/pull/28390#issuecomment-621408536
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org