You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/09/18 10:32:44 UTC
[GitHub] [incubator-kyuubi] lianneli opened a new pull request, #3509: [KYUUBI #3482]support select group name from ugi's GroupNames for group share level
lianneli opened a new pull request, #3509:
URL: https://github.com/apache/incubator-kyuubi/pull/3509
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3509: [KYUUBI #3482]support select group name from ugi's GroupNames for group share level
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3509:
URL: https://github.com/apache/incubator-kyuubi/pull/3509#discussion_r973704962
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1348,6 +1348,16 @@ object KyuubiConf {
.version("1.2.0")
.fallbackConf(LEGACY_ENGINE_SHARE_LEVEL)
+ val ENGINE_SHARE_LEVEL_GROUP_NAME: ConfigEntry[Option[String]] =
+ buildConf("kyuubi.engine.share.level.group.name")
Review Comment:
How about "kyuubi.engine.share.level.group.primaries"(`ConfigEntry[Seq[String]]`)?
And we can define the prefered list of group names.
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1348,6 +1348,16 @@ object KyuubiConf {
.version("1.2.0")
.fallbackConf(LEGACY_ENGINE_SHARE_LEVEL)
+ val ENGINE_SHARE_LEVEL_GROUP_NAME: ConfigEntry[Option[String]] =
+ buildConf("kyuubi.engine.share.level.group.name")
Review Comment:
How about "kyuubi.engine.share.level.group.primaries"(`ConfigEntry[Seq[String]]`)?
And we can define the preferred list of group names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3509: [KYUUBI #3482]support select group name from ugi's GroupNames for group share level
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3509:
URL: https://github.com/apache/incubator-kyuubi/pull/3509#discussion_r973705057
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1348,6 +1348,16 @@ object KyuubiConf {
.version("1.2.0")
.fallbackConf(LEGACY_ENGINE_SHARE_LEVEL)
+ val ENGINE_SHARE_LEVEL_GROUP_NAME: ConfigEntry[Option[String]] =
+ buildConf("kyuubi.engine.share.level.group.name")
Review Comment:
cc @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] github-actions[bot] commented on pull request #3509: [KYUUBI #3482]support select group name from ugi's GroupNames for group share level
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3509:
URL: https://github.com/apache/kyuubi/pull/3509#issuecomment-1366275211
Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!
Thank you for using Kyuubi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] github-actions[bot] closed pull request #3509: [KYUUBI #3482]support select group name from ugi's GroupNames for group share level
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3509: [KYUUBI #3482]support select group name from ugi's GroupNames for group share level
URL: https://github.com/apache/kyuubi/pull/3509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org