You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "LsomeYeah (via GitHub)" <gi...@apache.org> on 2025/01/07 11:30:26 UTC
[PR] [log] logging specific join keys and results for lookup join [paimon]
LsomeYeah opened a new pull request, #4856:
URL: https://github.com/apache/paimon/pull/4856
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #xxx
<!-- What is the purpose of the change -->
Add logs about join keys and join results when performing lookup join in `DEBUG` mode.
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [log] logging specific join keys and results for lookup join [paimon]
Posted by "wwj6591812 (via GitHub)" <gi...@apache.org>.
wwj6591812 commented on code in PR #4856:
URL: https://github.com/apache/paimon/pull/4856#discussion_r1905649239
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/lookup/FileStoreLookupFunction.java:
##########
@@ -264,6 +280,18 @@ private List<RowData> lookupInternal(InternalRow key) throws IOException {
for (InternalRow matchedRow : lookupResults) {
rows.add(new FlinkRowData(matchedRow));
}
+
+ try {
+ LOG.debug(
Review Comment:
if (LOG.isDebugEnabled()) {
LOG.debug("xxx");
}
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/lookup/FileStoreLookupFunction.java:
##########
@@ -413,4 +441,15 @@ protected Set<Integer> getRequireCachedBucketIds() {
protected void setCacheRowFilter(@Nullable Filter<InternalRow> cacheRowFilter) {
this.cacheRowFilter = cacheRowFilter;
}
+
+ private String logRow(List<InternalRow.FieldGetter> fieldGetters, InternalRow row) {
+ List<String> rowValues = new ArrayList<>(fieldGetters.size());
+
+ for (InternalRow.FieldGetter fieldGetter : fieldGetters) {
+ Object fieldValue = fieldGetter.getFieldOrNull(row);
+ String value = fieldValue == null ? "null" : fieldValue.toString();
+ rowValues.add(value);
Review Comment:
rowValues.add(fieldValue == null ? "null" : fieldValue.toString());
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/lookup/FileStoreLookupFunction.java:
##########
@@ -166,6 +179,8 @@ private void open() throws Exception {
List<String> fieldNames = table.rowType().getFieldNames();
int[] projection = projectFields.stream().mapToInt(fieldNames::indexOf).toArray();
+ LOG.info("lookup projection fields: {}, join fields:{}", projectFields, joinKeys);
Review Comment:
LOG.info("lookup projection fields: {}, join fields: {}.", projectFields, joinKeys);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [log] logging specific join keys and results for lookup join [paimon]
Posted by "yuzelin (via GitHub)" <gi...@apache.org>.
yuzelin merged PR #4856:
URL: https://github.com/apache/paimon/pull/4856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org