You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by ericcarlschwartz <gi...@git.apache.org> on 2017/02/22 21:01:13 UTC
[GitHub] trafficserver issue #1481: Log Field % always outputs "-"
GitHub user ericcarlschwartz opened an issue:
https://github.com/apache/trafficserver/issues/1481
Log Field %<cluc> always outputs "-"
Have been doing some testing with logging the cache key field %<cluc> and every log entry seems to simply be "-". Seeing this with 7.1.
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1481: Log Field % always outputs "-"
Posted by maskit <gi...@git.apache.org>.
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/issues/1481
I'm not 100% sure but it seems https://github.com/apache/trafficserver/commit/dda9df7ca7b886b5fd54d3ff6e9ed4f741948ba3 broke it. I reproduced the issue on master.
`LogAccessHttp::marshal_cache_lookup_url_canon` is not called due to a lack of `virtual`, and `LogAccess::marshal_cache_lookup_url_canon` is called instead.
I think the two special functions mentioned in the comment at https://github.com/apache/trafficserver/commit/dda9df7ca7b886b5fd54d3ff6e9ed4f741948ba3#diff-d24873824e07e2404c39103d90347585R273 should be `marshal_entry_type ` and `marshal_process_uuid`.
`marshal_cache_lookup_url_canon ` was originally declared as a virtual function.
https://github.com/apache/trafficserver/commit/719d55b67da2fc80a4ac77860085c4e595d3326c
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1481: Log Field % always outputs "-"
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1481
Yeh, I suck. Patch coming.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---