You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/14 19:49:40 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
rkhachatryan opened a new pull request #15206:
URL: https://github.com/apache/flink/pull/15206
## What is the purpose of the change
Trivial refactorings to allow customization
of readers and writers of heap state snapshots.
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #15206:
URL: https://github.com/apache/flink/pull/15206#discussion_r596844124
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateSnapshotRestore.java
##########
@@ -36,8 +39,10 @@
* hint.
*
* @param readVersionHint the required version of the state to read.
+ * @param dataInputStream the current dataInputStream.
* @return a reader that reads state by key-groups, for the given read version.
*/
@Nonnull
- StateSnapshotKeyGroupReader keyGroupReader(int readVersionHint);
+ StateSnapshotKeyGroupReader keyGroupReader(int readVersionHint, DataInputStream dataInputStream)
Review comment:
Could you please explain why adding `dataInputStream` could distinguish between full/inc snapshots on recovery?
Moreover, dose `StateSnapshotKeyGroupReader#readMappingsInKeyGroup(@Nonnull DataInputView div, @Nonnegative int keyGroupId)` still need that `div` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #15206:
URL: https://github.com/apache/flink/pull/15206#issuecomment-803650312
Thanks for the review @Myasuka. Build failure is unrelated (FLINK-21879), merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15206:
URL: https://github.com/apache/flink/pull/15206#issuecomment-798969998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e78660dd022b3beface3ea8307e8f89292127c03",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e78660dd022b3beface3ea8307e8f89292127c03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78660dd022b3beface3ea8307e8f89292127c03 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #15206:
URL: https://github.com/apache/flink/pull/15206#issuecomment-799398525
Build failure unrelated (FLINK-20420), private branch build [succeeded](https://dev.azure.com/khachatryanroman/flink/_build/results?buildId=703&view=results).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15206:
URL: https://github.com/apache/flink/pull/15206#issuecomment-798969998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e78660dd022b3beface3ea8307e8f89292127c03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14635",
"triggerID" : "e78660dd022b3beface3ea8307e8f89292127c03",
"triggerType" : "PUSH"
}, {
"hash" : "656da8a922893844c1c2c9643c9f448d50102615",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14763",
"triggerID" : "656da8a922893844c1c2c9643c9f448d50102615",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 656da8a922893844c1c2c9643c9f448d50102615 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14763)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #15206:
URL: https://github.com/apache/flink/pull/15206#discussion_r597624687
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateSnapshotRestore.java
##########
@@ -36,8 +39,10 @@
* hint.
*
* @param readVersionHint the required version of the state to read.
+ * @param dataInputStream the current dataInputStream.
* @return a reader that reads state by key-groups, for the given read version.
*/
@Nonnull
- StateSnapshotKeyGroupReader keyGroupReader(int readVersionHint);
+ StateSnapshotKeyGroupReader keyGroupReader(int readVersionHint, DataInputStream dataInputStream)
Review comment:
You are right, `inputView` can be passed once to `readMappingsInKeyGroup`.
I reverted the addition of parameter and increased the visibility of `StateTableByKeyGroupReaders`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15206:
URL: https://github.com/apache/flink/pull/15206#issuecomment-798969998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e78660dd022b3beface3ea8307e8f89292127c03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14635",
"triggerID" : "e78660dd022b3beface3ea8307e8f89292127c03",
"triggerType" : "PUSH"
}, {
"hash" : "656da8a922893844c1c2c9643c9f448d50102615",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14763",
"triggerID" : "656da8a922893844c1c2c9643c9f448d50102615",
"triggerType" : "PUSH"
}, {
"hash" : "a80d78f1dfe51b986de1e76302dfcda0ceb403f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15060",
"triggerID" : "a80d78f1dfe51b986de1e76302dfcda0ceb403f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a80d78f1dfe51b986de1e76302dfcda0ceb403f9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15060)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15206:
URL: https://github.com/apache/flink/pull/15206#issuecomment-798969998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e78660dd022b3beface3ea8307e8f89292127c03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14635",
"triggerID" : "e78660dd022b3beface3ea8307e8f89292127c03",
"triggerType" : "PUSH"
}, {
"hash" : "656da8a922893844c1c2c9643c9f448d50102615",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14763",
"triggerID" : "656da8a922893844c1c2c9643c9f448d50102615",
"triggerType" : "PUSH"
}, {
"hash" : "a80d78f1dfe51b986de1e76302dfcda0ceb403f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15060",
"triggerID" : "a80d78f1dfe51b986de1e76302dfcda0ceb403f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 656da8a922893844c1c2c9643c9f448d50102615 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14763)
* a80d78f1dfe51b986de1e76302dfcda0ceb403f9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15060)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15206:
URL: https://github.com/apache/flink/pull/15206#issuecomment-798968589
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e78660dd022b3beface3ea8307e8f89292127c03 (Sun Mar 14 19:52:00 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15206:
URL: https://github.com/apache/flink/pull/15206#issuecomment-798969998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e78660dd022b3beface3ea8307e8f89292127c03",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14635",
"triggerID" : "e78660dd022b3beface3ea8307e8f89292127c03",
"triggerType" : "PUSH"
}, {
"hash" : "656da8a922893844c1c2c9643c9f448d50102615",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "656da8a922893844c1c2c9643c9f448d50102615",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78660dd022b3beface3ea8307e8f89292127c03 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14635)
* 656da8a922893844c1c2c9643c9f448d50102615 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15206:
URL: https://github.com/apache/flink/pull/15206#issuecomment-798969998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e78660dd022b3beface3ea8307e8f89292127c03",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14635",
"triggerID" : "e78660dd022b3beface3ea8307e8f89292127c03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78660dd022b3beface3ea8307e8f89292127c03 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14635)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15206:
URL: https://github.com/apache/flink/pull/15206#issuecomment-798969998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e78660dd022b3beface3ea8307e8f89292127c03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14635",
"triggerID" : "e78660dd022b3beface3ea8307e8f89292127c03",
"triggerType" : "PUSH"
}, {
"hash" : "656da8a922893844c1c2c9643c9f448d50102615",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14763",
"triggerID" : "656da8a922893844c1c2c9643c9f448d50102615",
"triggerType" : "PUSH"
}, {
"hash" : "a80d78f1dfe51b986de1e76302dfcda0ceb403f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a80d78f1dfe51b986de1e76302dfcda0ceb403f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 656da8a922893844c1c2c9643c9f448d50102615 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14763)
* a80d78f1dfe51b986de1e76302dfcda0ceb403f9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15206:
URL: https://github.com/apache/flink/pull/15206#issuecomment-798969998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e78660dd022b3beface3ea8307e8f89292127c03",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14635",
"triggerID" : "e78660dd022b3beface3ea8307e8f89292127c03",
"triggerType" : "PUSH"
}, {
"hash" : "656da8a922893844c1c2c9643c9f448d50102615",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14763",
"triggerID" : "656da8a922893844c1c2c9643c9f448d50102615",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78660dd022b3beface3ea8307e8f89292127c03 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14635)
* 656da8a922893844c1c2c9643c9f448d50102615 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14763)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan merged pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #15206:
URL: https://github.com/apache/flink/pull/15206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15206: [FLINK-21673] Add extension points to snapshot reading/wr…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15206:
URL: https://github.com/apache/flink/pull/15206#issuecomment-798969998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e78660dd022b3beface3ea8307e8f89292127c03",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14635",
"triggerID" : "e78660dd022b3beface3ea8307e8f89292127c03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e78660dd022b3beface3ea8307e8f89292127c03 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14635)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org