You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2015/02/16 16:31:40 UTC

[GitHub] flink pull request: [FLINK-1556] Corrects faulty JobClient behavio...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/406

    [FLINK-1556] Corrects faulty JobClient behaviour in case of a submission failure

    If an error occurred during job submission, a ```SubmissionFailure``` is sent to the ```JobClient```. As a reaction, the ```JobClient``` terminated itself and sent the failure to the ```Client```. However, this does not necessarily mean that the job has reached a terminal state, because the failing procedure is executed asynchronously.
    
    The ```JobClient``` now waits until it receives a ```JobResult``` message indicating that the job has completed and all resources are properly returned.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink minorFixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/406.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #406
    
----
commit 2f32e9c6b87b8e295f792c04306d78fbb858f80d
Author: Till Rohrmann <tr...@apache.org>
Date:   2015-02-16T09:17:21Z

    [FLINK-1556] [runtime] Corrects faulty JobClient behaviour in case of a submission failure

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1556] Corrects faulty JobClient behavio...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/406#issuecomment-74565029
  
    Looks good to me!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1556] Corrects faulty JobClient behavio...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/406#issuecomment-74633679
  
    Ok, I'll merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1556] Corrects faulty JobClient behavio...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/406


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---