You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gossip.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/18 12:25:00 UTC
[jira] [Commented] (GOSSIP-89) Refactor Examples
[ https://issues.apache.org/jira/browse/GOSSIP-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091481#comment-16091481 ]
ASF GitHub Bot commented on GOSSIP-89:
--------------------------------------
GitHub user Terry-Weymouth opened a pull request:
https://github.com/apache/incubator-gossip/pull/64
GOSSIP-89 - Refactor gossip examples; common code in base class.
I moved common code for the 'Stand Alone' examples into an Abstract class. See GOSSIP-89
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Terry-Weymouth/incubator-gossip GOSSIP-89
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gossip/pull/64.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #64
----
commit 1c673c859719e99f24ecc3ffed882667a14c44fd
Author: Terry Weymouth <we...@umich.edu>
Date: 2017-07-01T14:19:24Z
GOSSIP-89 - Refactor gossip examples; common code in base class.
----
> Refactor Examples
> -----------------
>
> Key: GOSSIP-89
> URL: https://issues.apache.org/jira/browse/GOSSIP-89
> Project: Gossip
> Issue Type: Improvement
> Affects Versions: 0.1.3
> Reporter: Terry Weymouth
> Assignee: Terry Weymouth
> Priority: Minor
> Fix For: 0.1.3
>
>
> I'd like to look into refactoring the examples (in gossip-examples) by moving common code in a new super-class; the goal would be to provide an abstract framework that would make writing new examples easer and (perhaps) make the existing examples more compact and understandable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)