You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Mohamed Nufail (JIRA)" <ji...@apache.org> on 2012/06/03 13:57:23 UTC
[jira] [Updated] (DERBY-5786) Duplicate copies of
InputStreamUtil.java and DynamicByteArrayOutputStream.java classes in
client.net package
[ https://issues.apache.org/jira/browse/DERBY-5786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mohamed Nufail updated DERBY-5786:
----------------------------------
Attachment: DERBY-5786.patch
Attached a patch with the following changes.
- Remove the two classes InputStreamUtil and DynamicByteArrayOutputStream
- Move out PublicBufferOutputStream from EncodedInputStream and make it a standalone class
- Do required changes in Request.java
> Duplicate copies of InputStreamUtil.java and DynamicByteArrayOutputStream.java classes in client.net package
> ------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-5786
> URL: https://issues.apache.org/jira/browse/DERBY-5786
> Project: Derby
> Issue Type: Task
> Reporter: Mohamed Nufail
> Assignee: Mohamed Nufail
> Priority: Minor
> Attachments: DERBY-5786.patch
>
>
> In solving DERBY-4491, InputStreamUtil.java and DynamicByteArrayOutputStream.java classes which are present in org.apache.derby.iapi.services.io package was needed for the network client also. So now there are duplicate copies of those classes in org.apache.derby.client.net package.
> But the client uses only a small part of the functionality those classes provide. In a discussion in dev list (http://mail-archives.apache.org/mod_mbox/db-derby-dev/201205.mbox/%3Cwjo8r4ucgtfv.fsf%40oracle.com%3E) it was decided to use EncodedInputStream.PublicBufferOutputStream which is already in the client.net package instead of the duplicated classes. In order to do this PublicBufferOutputStream will first be made into a stand-alone class.
> Doing this would help to reduce the code size and increase code coverage, as the duplicate classes currently have no code coverage.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira