You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Yu Li (Jira)" <ji...@apache.org> on 2019/12/12 12:15:00 UTC
[jira] [Updated] (FLINK-15222) Move state benchmark utils into core
repository
[ https://issues.apache.org/jira/browse/FLINK-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yu Li updated FLINK-15222:
--------------------------
Description:
Currently we're maintaining the state benchmark utils in the [flink-benchmark|https://github.com/dataArtisans/flink-benchmarks] repository instead of core repository, which not only make it hard to find out compatibility issues if state backend codes are refactored and will cause problems like FLINK-15199, but also disobeys the instructions of flink-benchmark project:
{quote}
Recommended code structure is to define all benchmarks in Apache Flink and only wrap them here, in this repository, into executor classes.
Such code structured is due to using GPL2 licensed jmh library for the actual execution of the benchmarks. Ideally we would prefer to have all of the code moved to Apache Flink
{quote}
We will improve this and prevent future incompatible problem in this JIRA.
was:
Currently we're maintaining the state benchmark utils in the flink-benchmark repository instead of core repository, which not only make it hard to find out compatibility issues if state backend codes are refactored and will cause problems like FLINK-15199, but also disobeys the instructions of flink-benchmark project:
{quote}
Recommended code structure is to define all benchmarks in Apache Flink and only wrap them here, in this repository, into executor classes.
Such code structured is due to using GPL2 licensed jmh library for the actual execution of the benchmarks. Ideally we would prefer to have all of the code moved to Apache Flink
{quote}
We will improve this and prevent future incompatible problem in this JIRA.
> Move state benchmark utils into core repository
> -----------------------------------------------
>
> Key: FLINK-15222
> URL: https://issues.apache.org/jira/browse/FLINK-15222
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / State Backends
> Reporter: Yu Li
> Priority: Major
>
> Currently we're maintaining the state benchmark utils in the [flink-benchmark|https://github.com/dataArtisans/flink-benchmarks] repository instead of core repository, which not only make it hard to find out compatibility issues if state backend codes are refactored and will cause problems like FLINK-15199, but also disobeys the instructions of flink-benchmark project:
> {quote}
> Recommended code structure is to define all benchmarks in Apache Flink and only wrap them here, in this repository, into executor classes.
> Such code structured is due to using GPL2 licensed jmh library for the actual execution of the benchmarks. Ideally we would prefer to have all of the code moved to Apache Flink
> {quote}
> We will improve this and prevent future incompatible problem in this JIRA.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)