You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kh...@apache.org on 2017/05/07 13:24:25 UTC
svn commit: r1794196 - in
/maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/deploy:
ProjectDeployer.java internal/DefaultProjectDeployer.java
Author: khmarbaise
Date: Sun May 7 13:24:25 2017
New Revision: 1794196
URL: http://svn.apache.org/viewvc?rev=1794196&view=rev
Log:
[MSHARED-637] Remove IOException from ProjectDeployer cause it's not thrown by the code
o Fixed duplicated license header ProjectDeployer.
o Changed the deploy() method and removed IOException and added IllegalArgumentException
Modified:
maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/deploy/ProjectDeployer.java
maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/deploy/internal/DefaultProjectDeployer.java
Modified: maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/deploy/ProjectDeployer.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/deploy/ProjectDeployer.java?rev=1794196&r1=1794195&r2=1794196&view=diff
==============================================================================
--- maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/deploy/ProjectDeployer.java (original)
+++ maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/deploy/ProjectDeployer.java Sun May 7 13:24:25 2017
@@ -19,27 +19,6 @@ package org.apache.maven.shared.project.
* under the License.
*/
-import java.io.IOException;
-
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
import org.apache.maven.artifact.repository.ArtifactRepository;
import org.apache.maven.project.ProjectBuildingRequest;
import org.apache.maven.shared.project.NoFileAssignedException;
@@ -75,12 +54,12 @@ public interface ProjectDeployer
* @param buildingRequest {@link ProjectBuildingRequest}
* @param request {@link ProjectDeployerRequest}
* @param artifactRepository {@link ArtifactRepository}
- * @throws IOException In case of problems related to checksums.
* @throws NoFileAssignedException In case of missing file which has not been assigned to project.
+ * @throws IllegalArgumentException in case of artifact is not correctly assigned.
*/
- //FIXME: Need to check to remove IOException cause it looks like it's not being thrown by code.
void deploy( ProjectBuildingRequest buildingRequest, ProjectDeployerRequest request,
ArtifactRepository artifactRepository )
- throws IOException, NoFileAssignedException;
+ throws NoFileAssignedException, IllegalArgumentException;
+
}
Modified: maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/deploy/internal/DefaultProjectDeployer.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/deploy/internal/DefaultProjectDeployer.java?rev=1794196&r1=1794195&r2=1794196&view=diff
==============================================================================
--- maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/deploy/internal/DefaultProjectDeployer.java (original)
+++ maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/deploy/internal/DefaultProjectDeployer.java Sun May 7 13:24:25 2017
@@ -20,7 +20,6 @@ package org.apache.maven.shared.project.
*/
import java.io.File;
-import java.io.IOException;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
@@ -66,7 +65,7 @@ public class DefaultProjectDeployer
*/
public void deploy( ProjectBuildingRequest buildingRequest, ProjectDeployerRequest request,
ArtifactRepository artifactRepository )
- throws IOException, NoFileAssignedException
+ throws NoFileAssignedException, IllegalArgumentException
{
Artifact artifact = request.getProject().getArtifact();