[jira] [Commented] (IGNITE-15128) Take own control of SQL functions

["Konstantin Orlov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-15128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442440#comment-17442440 ] 

Konstantin Orlov commented on IGNITE-15128:
-------------------------------------------

[~alex_pl], the patch looks good to me except a few minors. Feel free to ignore them and merge the patch as is.

> Take own control of SQL functions
> ---------------------------------
>
>                 Key: IGNITE-15128
>                 URL: https://issues.apache.org/jira/browse/IGNITE-15128
>             Project: Ignite
>          Issue Type: Improvement
>          Components: sql
>            Reporter: Yury Gerzhedovich
>            Assignee: Aleksey Plekhanov
>            Priority: Major
>              Labels: calcite2-required, calcite3-required
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> As of now, we use a set of 4 database function dialects:
> SqlLibrary.STANDARD,
> SqlLibrary.POSTGRESQL,
> SqlLibrary.ORACLE,
> SqlLibrary.MYSQL
> Seems we should have owned our dialect with a subset of the aforementioned functions and have the ability to modify already exists functions and add a new one.
> During implementation need to sort out similar functions and choose just one of them to avoid duplication, 
> See :
> org.apache.calcite.util.BuiltInMethod
> org.apache.calcite.sql.fun.SqlLibraryOperators
> org.apache.calcite.runtime.SqlFunctions
> org.apache.ignite.internal.processors.query.calcite.exec.exp.RexImpTable



--
This message was sent by Atlassian Jira
(v8.20.1#820001)