You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/11 03:12:38 UTC

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #5036: [QNN] Support 4D padding.

FrozenGene commented on a change in pull request #5036: [QNN] Support 4D padding.
URL: https://github.com/apache/incubator-tvm/pull/5036#discussion_r390724232
 
 

 ##########
 File path: python/tvm/relay/qnn/op/qnn.py
 ##########
 @@ -280,6 +281,9 @@ def conv2d(data,
         The computed result.
     """
 
+    # TODO enforce 4-way padding in topi/nn/conv2d after #4644 merged
+    # convert 2-way padding to 4-way padding
 
 Review comment:
   Why this is related with #4644?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services