[GitHub] [ignite-3] sanpwc commented on a change in pull request #611: IGNITE-16434 @InternalId integration for table id.

[GitBox <gi...@apache.org>]

sanpwc commented on a change in pull request #611:
URL: https://github.com/apache/ignite-3/pull/611#discussion_r796500343



##########
File path: modules/configuration/src/main/java/org/apache/ignite/internal/configuration/tree/NamedListNode.java
##########
@@ -489,9 +489,26 @@ public void construct(String key, ConfigurationSource src, boolean includeIntern
 
         newElement.setInjectedNameFieldValue(key);
 
+        newElement.internalId(generateInternalId());
+
         return new ElementDescriptor(newElement);
     }
 
+    /**
+     * Generates a new unique internal id for the node.
+     *
+     * @return Generated internal id.
+     */
+    private UUID generateInternalId() {

Review comment:
       Will it be regenerated for "pending" changes on every iteration of cfg apply process if invoke to ms failed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org