You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@openmeetings.apache.org by Michael Wuttke <mw...@beuth-hochschule.de> on 2016/05/15 10:47:09 UTC

two issues with the new openmeetings moodle plugin

Hello Maxim,

I have found two issues installing the new openmeetings moodle plugin
(version 2.0.0.1). I tested to upgrade the plugin from version 1.7.5 to
version 2.0.01 on moodle 2.9 and moodle 3.0 on postgresql.

1. the renaming of the settings strings (red5host -> host, red5port ->
port, openmeetingsAdminUser -> user, openmeetingsAdminUserPass -> pass &
openmeetingsModuleKey -> moduleKey) effect that the settings are set to
default during the update process and not taken from the previous
local/costum installation.

2. the change of the type of the field 'type' on mdl_openmeetings from
int to character varying(16): creating new rooms will end up with the
following error:

Debug info: FEHLER: ung�ltige Eingabesyntax f�r ganze Zahl: \u201econference\u201c
INSERT INTO mdl_openmeetings
(name,room_id,type,max_user,language,is_moderated_room,allow_recording,whole_window,room_recording_id,course,intro)
VALUES($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11) RETURNING id
[array (
'name' => 'test room moodle29 conference inframe',
'room_id' => 54,
'type' => 'conference',
'max_user' => '2',
'language' => '1',
'is_moderated_room' => '1',
'allow_recording' => '1',
'whole_window' => '0',
'room_recording_id' => '9',
'course' => '2',
'intro' => '<p>test room moodle29 conference inframe<br></p>',
)]
Error code: dmlwriteexception
Stack trace:

    line 446 of /lib/dml/moodle_database.php: dml_write_exception thrown
    line 244 of /lib/dml/pgsql_native_moodle_database.php: call to
moodle_database->query_end()
    line 868 of /lib/dml/pgsql_native_moodle_database.php: call to
pgsql_native_moodle_database->query_end()
    line 924 of /lib/dml/pgsql_native_moodle_database.php: call to
pgsql_native_moodle_database->insert_record_raw()
    line 132 of /mod/openmeetings/lib.php: call to
pgsql_native_moodle_database->insert_record()
    line 121 of /course/modlib.php: call to openmeetings_add_instance()
    line 274 of /course/modedit.php: call to add_moduleinfo()

See also issue #9 on github:
https://github.com/openmeetings/openmeetings-moodle-plugin/issues/9

For the second point I created a pull request on github:
https://github.com/openmeetings/openmeetings-moodle-plugin/pull/10

Thanks & Greetings,
Michael

Re: two issues with the new openmeetings moodle plugin

Posted by Michael Wuttke <mw...@beuth-hochschule.de>.
Great! Thanks a lot!

Michael

Am 16.05.2016 um 12:07 schrieb Maxim Solodovnik:
> Seems to be done :)
> build #1 is in progress :)
> 
> On Mon, May 16, 2016 at 12:53 AM, Michael Wuttke
> <mwuttke@beuth-hochschule.de <ma...@beuth-hochschule.de>> wrote:
> 
>     Hello Maxim,
> 
>     no problem. ;-)
> 
>     But one thing. Please Could you configure your github repository of the
>     openmeetings moodle plugin for travis ci?
> 
>     A good small howto to connect the github repository with travis-ci you
>     can find here:
>     https://github.com/moodlerooms/moodle-plugin-ci/blob/master/README.md
> 
>     The travis-ci site for the openmeetings moodle plugin you can find here:
>     https://travis-ci.org/openmeetings/openmeetings-moodle-plugin
> 
>     And at the end, could you change the README.md to this site? Or you kick
>     out the travis-ci button from the README.md.
> 
>     Thanks & Greetings,
>     Michael
> 
>     Am 15.05.2016 um 15:05 schrieb Maxim Solodovnik:
>     > Merged, sorry for PR #8, I was sure I have merged it :(
>     >
>     > On Sun, May 15, 2016 at 4:47 PM, Michael Wuttke
>     > <mwuttke@beuth-hochschule.de <ma...@beuth-hochschule.de>
>     <mailto:mwuttke@beuth-hochschule.de
>     <ma...@beuth-hochschule.de>>> wrote:
>     >
>     >     Hello Maxim,
>     >
>     >     I have found two issues installing the new openmeetings moodle
>     plugin
>     >     (version 2.0.0.1). I tested to upgrade the plugin from version
>     1.7.5 to
>     >     version 2.0.01 on moodle 2.9 and moodle 3.0 on postgresql.
>     >
>     >     1. the renaming of the settings strings (red5host -> host,
>     red5port ->
>     >     port, openmeetingsAdminUser -> user, openmeetingsAdminUserPass
>     -> pass &
>     >     openmeetingsModuleKey -> moduleKey) effect that the settings
>     are set to
>     >     default during the update process and not taken from the previous
>     >     local/costum installation.
>     >
>     >     2. the change of the type of the field 'type' on
>     mdl_openmeetings from
>     >     int to character varying(16): creating new rooms will end up
>     with the
>     >     following error:
>     >
>     >     Debug info: FEHLER: ung�ltige Eingabesyntax f�r ganze Zahl:
>     \u201econference\u201c
>     >     INSERT INTO mdl_openmeetings
>     >   
>      (name,room_id,type,max_user,language,is_moderated_room,allow_recording,whole_window,room_recording_id,course,intro)
>     >     VALUES($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11) RETURNING id
>     >     [array (
>     >     'name' => 'test room moodle29 conference inframe',
>     >     'room_id' => 54,
>     >     'type' => 'conference',
>     >     'max_user' => '2',
>     >     'language' => '1',
>     >     'is_moderated_room' => '1',
>     >     'allow_recording' => '1',
>     >     'whole_window' => '0',
>     >     'room_recording_id' => '9',
>     >     'course' => '2',
>     >     'intro' => '<p>test room moodle29 conference inframe<br></p>',
>     >     )]
>     >     Error code: dmlwriteexception
>     >     Stack trace:
>     >
>     >         line 446 of /lib/dml/moodle_database.php:
>     dml_write_exception thrown
>     >         line 244 of /lib/dml/pgsql_native_moodle_database.php: call to
>     >     moodle_database->query_end()
>     >         line 868 of /lib/dml/pgsql_native_moodle_database.php: call to
>     >     pgsql_native_moodle_database->query_end()
>     >         line 924 of /lib/dml/pgsql_native_moodle_database.php: call to
>     >     pgsql_native_moodle_database->insert_record_raw()
>     >         line 132 of /mod/openmeetings/lib.php: call to
>     >     pgsql_native_moodle_database->insert_record()
>     >         line 121 of /course/modlib.php: call to
>     openmeetings_add_instance()
>     >         line 274 of /course/modedit.php: call to add_moduleinfo()
>     >
>     >     See also issue #9 on github:
>     >   
>      https://github.com/openmeetings/openmeetings-moodle-plugin/issues/9
>     >
>     >     For the second point I created a pull request on github:
>     >     https://github.com/openmeetings/openmeetings-moodle-plugin/pull/10
>     >
>     >     Thanks & Greetings,
>     >     Michael
>     >
>     >
>     >
>     >
>     > --
>     > WBR
>     > Maxim aka solomax
> 
> 
> 
> 
> -- 
> WBR
> Maxim aka solomax

Re: two issues with the new openmeetings moodle plugin

Posted by Maxim Solodovnik <so...@gmail.com>.
Seems to be done :)
build #1 is in progress :)

On Mon, May 16, 2016 at 12:53 AM, Michael Wuttke <
mwuttke@beuth-hochschule.de> wrote:

> Hello Maxim,
>
> no problem. ;-)
>
> But one thing. Please Could you configure your github repository of the
> openmeetings moodle plugin for travis ci?
>
> A good small howto to connect the github repository with travis-ci you
> can find here:
> https://github.com/moodlerooms/moodle-plugin-ci/blob/master/README.md
>
> The travis-ci site for the openmeetings moodle plugin you can find here:
> https://travis-ci.org/openmeetings/openmeetings-moodle-plugin
>
> And at the end, could you change the README.md to this site? Or you kick
> out the travis-ci button from the README.md.
>
> Thanks & Greetings,
> Michael
>
> Am 15.05.2016 um 15:05 schrieb Maxim Solodovnik:
> > Merged, sorry for PR #8, I was sure I have merged it :(
> >
> > On Sun, May 15, 2016 at 4:47 PM, Michael Wuttke
> > <mwuttke@beuth-hochschule.de <ma...@beuth-hochschule.de>>
> wrote:
> >
> >     Hello Maxim,
> >
> >     I have found two issues installing the new openmeetings moodle plugin
> >     (version 2.0.0.1). I tested to upgrade the plugin from version 1.7.5
> to
> >     version 2.0.01 on moodle 2.9 and moodle 3.0 on postgresql.
> >
> >     1. the renaming of the settings strings (red5host -> host, red5port
> ->
> >     port, openmeetingsAdminUser -> user, openmeetingsAdminUserPass ->
> pass &
> >     openmeetingsModuleKey -> moduleKey) effect that the settings are set
> to
> >     default during the update process and not taken from the previous
> >     local/costum installation.
> >
> >     2. the change of the type of the field 'type' on mdl_openmeetings
> from
> >     int to character varying(16): creating new rooms will end up with the
> >     following error:
> >
> >     Debug info: FEHLER: ungültige Eingabesyntax für ganze Zahl:
> „conference“
> >     INSERT INTO mdl_openmeetings
> >
>  (name,room_id,type,max_user,language,is_moderated_room,allow_recording,whole_window,room_recording_id,course,intro)
> >     VALUES($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11) RETURNING id
> >     [array (
> >     'name' => 'test room moodle29 conference inframe',
> >     'room_id' => 54,
> >     'type' => 'conference',
> >     'max_user' => '2',
> >     'language' => '1',
> >     'is_moderated_room' => '1',
> >     'allow_recording' => '1',
> >     'whole_window' => '0',
> >     'room_recording_id' => '9',
> >     'course' => '2',
> >     'intro' => '<p>test room moodle29 conference inframe<br></p>',
> >     )]
> >     Error code: dmlwriteexception
> >     Stack trace:
> >
> >         line 446 of /lib/dml/moodle_database.php: dml_write_exception
> thrown
> >         line 244 of /lib/dml/pgsql_native_moodle_database.php: call to
> >     moodle_database->query_end()
> >         line 868 of /lib/dml/pgsql_native_moodle_database.php: call to
> >     pgsql_native_moodle_database->query_end()
> >         line 924 of /lib/dml/pgsql_native_moodle_database.php: call to
> >     pgsql_native_moodle_database->insert_record_raw()
> >         line 132 of /mod/openmeetings/lib.php: call to
> >     pgsql_native_moodle_database->insert_record()
> >         line 121 of /course/modlib.php: call to
> openmeetings_add_instance()
> >         line 274 of /course/modedit.php: call to add_moduleinfo()
> >
> >     See also issue #9 on github:
> >     https://github.com/openmeetings/openmeetings-moodle-plugin/issues/9
> >
> >     For the second point I created a pull request on github:
> >     https://github.com/openmeetings/openmeetings-moodle-plugin/pull/10
> >
> >     Thanks & Greetings,
> >     Michael
> >
> >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
>



-- 
WBR
Maxim aka solomax

Re: two issues with the new openmeetings moodle plugin

Posted by Michael Wuttke <mw...@beuth-hochschule.de>.
Hello Maxim,

no problem. ;-)

But one thing. Please Could you configure your github repository of the
openmeetings moodle plugin for travis ci?

A good small howto to connect the github repository with travis-ci you
can find here:
https://github.com/moodlerooms/moodle-plugin-ci/blob/master/README.md

The travis-ci site for the openmeetings moodle plugin you can find here:
https://travis-ci.org/openmeetings/openmeetings-moodle-plugin

And at the end, could you change the README.md to this site? Or you kick
out the travis-ci button from the README.md.

Thanks & Greetings,
Michael

Am 15.05.2016 um 15:05 schrieb Maxim Solodovnik:
> Merged, sorry for PR #8, I was sure I have merged it :(
> 
> On Sun, May 15, 2016 at 4:47 PM, Michael Wuttke
> <mwuttke@beuth-hochschule.de <ma...@beuth-hochschule.de>> wrote:
> 
>     Hello Maxim,
> 
>     I have found two issues installing the new openmeetings moodle plugin
>     (version 2.0.0.1). I tested to upgrade the plugin from version 1.7.5 to
>     version 2.0.01 on moodle 2.9 and moodle 3.0 on postgresql.
> 
>     1. the renaming of the settings strings (red5host -> host, red5port ->
>     port, openmeetingsAdminUser -> user, openmeetingsAdminUserPass -> pass &
>     openmeetingsModuleKey -> moduleKey) effect that the settings are set to
>     default during the update process and not taken from the previous
>     local/costum installation.
> 
>     2. the change of the type of the field 'type' on mdl_openmeetings from
>     int to character varying(16): creating new rooms will end up with the
>     following error:
> 
>     Debug info: FEHLER: ung�ltige Eingabesyntax f�r ganze Zahl: \u201econference\u201c
>     INSERT INTO mdl_openmeetings
>     (name,room_id,type,max_user,language,is_moderated_room,allow_recording,whole_window,room_recording_id,course,intro)
>     VALUES($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11) RETURNING id
>     [array (
>     'name' => 'test room moodle29 conference inframe',
>     'room_id' => 54,
>     'type' => 'conference',
>     'max_user' => '2',
>     'language' => '1',
>     'is_moderated_room' => '1',
>     'allow_recording' => '1',
>     'whole_window' => '0',
>     'room_recording_id' => '9',
>     'course' => '2',
>     'intro' => '<p>test room moodle29 conference inframe<br></p>',
>     )]
>     Error code: dmlwriteexception
>     Stack trace:
> 
>         line 446 of /lib/dml/moodle_database.php: dml_write_exception thrown
>         line 244 of /lib/dml/pgsql_native_moodle_database.php: call to
>     moodle_database->query_end()
>         line 868 of /lib/dml/pgsql_native_moodle_database.php: call to
>     pgsql_native_moodle_database->query_end()
>         line 924 of /lib/dml/pgsql_native_moodle_database.php: call to
>     pgsql_native_moodle_database->insert_record_raw()
>         line 132 of /mod/openmeetings/lib.php: call to
>     pgsql_native_moodle_database->insert_record()
>         line 121 of /course/modlib.php: call to openmeetings_add_instance()
>         line 274 of /course/modedit.php: call to add_moduleinfo()
> 
>     See also issue #9 on github:
>     https://github.com/openmeetings/openmeetings-moodle-plugin/issues/9
> 
>     For the second point I created a pull request on github:
>     https://github.com/openmeetings/openmeetings-moodle-plugin/pull/10
> 
>     Thanks & Greetings,
>     Michael
> 
> 
> 
> 
> -- 
> WBR
> Maxim aka solomax

Re: two issues with the new openmeetings moodle plugin

Posted by Maxim Solodovnik <so...@gmail.com>.
Merged, sorry for PR #8, I was sure I have merged it :(

On Sun, May 15, 2016 at 4:47 PM, Michael Wuttke <mwuttke@beuth-hochschule.de
> wrote:

> Hello Maxim,
>
> I have found two issues installing the new openmeetings moodle plugin
> (version 2.0.0.1). I tested to upgrade the plugin from version 1.7.5 to
> version 2.0.01 on moodle 2.9 and moodle 3.0 on postgresql.
>
> 1. the renaming of the settings strings (red5host -> host, red5port ->
> port, openmeetingsAdminUser -> user, openmeetingsAdminUserPass -> pass &
> openmeetingsModuleKey -> moduleKey) effect that the settings are set to
> default during the update process and not taken from the previous
> local/costum installation.
>
> 2. the change of the type of the field 'type' on mdl_openmeetings from
> int to character varying(16): creating new rooms will end up with the
> following error:
>
> Debug info: FEHLER: ungültige Eingabesyntax für ganze Zahl: „conference“
> INSERT INTO mdl_openmeetings
>
> (name,room_id,type,max_user,language,is_moderated_room,allow_recording,whole_window,room_recording_id,course,intro)
> VALUES($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11) RETURNING id
> [array (
> 'name' => 'test room moodle29 conference inframe',
> 'room_id' => 54,
> 'type' => 'conference',
> 'max_user' => '2',
> 'language' => '1',
> 'is_moderated_room' => '1',
> 'allow_recording' => '1',
> 'whole_window' => '0',
> 'room_recording_id' => '9',
> 'course' => '2',
> 'intro' => '<p>test room moodle29 conference inframe<br></p>',
> )]
> Error code: dmlwriteexception
> Stack trace:
>
>     line 446 of /lib/dml/moodle_database.php: dml_write_exception thrown
>     line 244 of /lib/dml/pgsql_native_moodle_database.php: call to
> moodle_database->query_end()
>     line 868 of /lib/dml/pgsql_native_moodle_database.php: call to
> pgsql_native_moodle_database->query_end()
>     line 924 of /lib/dml/pgsql_native_moodle_database.php: call to
> pgsql_native_moodle_database->insert_record_raw()
>     line 132 of /mod/openmeetings/lib.php: call to
> pgsql_native_moodle_database->insert_record()
>     line 121 of /course/modlib.php: call to openmeetings_add_instance()
>     line 274 of /course/modedit.php: call to add_moduleinfo()
>
> See also issue #9 on github:
> https://github.com/openmeetings/openmeetings-moodle-plugin/issues/9
>
> For the second point I created a pull request on github:
> https://github.com/openmeetings/openmeetings-moodle-plugin/pull/10
>
> Thanks & Greetings,
> Michael
>



-- 
WBR
Maxim aka solomax