You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2018/02/01 04:33:25 UTC

[2/3] impala git commit: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out

IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out

Log the memz, metrics and query page if the method wait_for_metric_value
times out. This would help us understand the state of the defaulting
impalad when the time out happens.

Change-Id: I069dad48ede709c4114f4d7175861f98321be6cf
Reviewed-on: http://gerrit.cloudera.org:8080/9098
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/cb2fa247
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/cb2fa247
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/cb2fa247

Branch: refs/heads/master
Commit: cb2fa2475ee504c9d849a7a139b89c55cc59ce30
Parents: 4b16ecd
Author: Bikramjeet Vig <bi...@cloudera.com>
Authored: Wed Jan 17 14:23:27 2018 -0800
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Thu Feb 1 02:26:50 2018 +0000

----------------------------------------------------------------------
 tests/common/impala_service.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/cb2fa247/tests/common/impala_service.py
----------------------------------------------------------------------
diff --git a/tests/common/impala_service.py b/tests/common/impala_service.py
index dfd4a6e..3ad0e84 100644
--- a/tests/common/impala_service.py
+++ b/tests/common/impala_service.py
@@ -115,8 +115,14 @@ class BaseImpalaService(object):
             (metric_name, expected_value, value))
       LOG.info("Sleeping %ds before next retry." % interval)
       sleep(interval)
-    assert 0, 'Metric value %s did not reach value %s in %ss' %\
-        (metric_name, expected_value, timeout)
+    assert 0, 'Metric value %s did not reach value %s in %ss\nDumping impalad debug ' \
+              'pages:\nmemz: %s\nmetrics: %s\nqueries: %s\nthreadz: %s\nrpcz: %s' % \
+              (metric_name, expected_value, timeout,
+               json.dumps(self.read_debug_webpage('memz?json')),
+               json.dumps(self.read_debug_webpage('metrics?json')),
+               json.dumps(self.read_debug_webpage('queries?json')),
+               json.dumps(self.read_debug_webpage('threadz?json')),
+               json.dumps(self.read_debug_webpage('rpcz?json')))
 
 # Allows for interacting with an Impalad instance to perform operations such as creating
 # new connections or accessing the debug webpage.