You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/04/07 11:05:40 UTC
Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/
-----------------------------------------------------------
Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6
Diff: https://reviews.apache.org/r/58263/diff/1/
Testing
-------
make check on Mac OS and various Linux distros.
Thanks,
Alexander Rukletsov
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review171345
-----------------------------------------------------------
```
I0407 11:44:08.444990 22135 linux_launcher.cpp:429] Launching nested container af12f877-9ba3-4bcf-a909-24c47d796cb8.b5c0c3b1-d124-4af4-a4a5-5d6868242575 and cloning with namespaces
I0407 11:44:08.474304 22133 fetcher.cpp:353] Starting to fetch URIs for container: af12f877-9ba3-4bcf-a909-24c47d796cb8.b5c0c3b1-d124-4af4-a4a5-5d6868242575, directory: /tmp/NestedMesosContainerizerTest_ROOT_CGROUPS_CURL_INTERNET_LaunchNestedDebugCheckMntNamespace_Db0xy2/slaves/2bae98f0-6967-4cb6-a4c0-f48b70bb5ec8-S0/frameworks/2bae98f0-6967-4cb6-a4c0-f48b70bb5ec8-0000/executors/d01a9376-25b1-48d1-a5a5-5c5a287dfcc7/runs/af12f877-9ba3-4bcf-a909-24c47d796cb8/containers/b5c0c3b1-d124-4af4-a4a5-5d6868242575
Failed to chdir into current working directory '/tmp/NestedMesosContainerizerTest_ROOT_CGROUPS_CURL_INTERNET_LaunchNestedDebugCheckMntNamespace_Db0xy2/slaves/2bae98f0-6967-4cb6-a4c0-f48b70bb5ec8-S0/frameworks/2bae98f0-6967-4cb6-a4c0-f48b70bb5ec8-0000/executors/d01a9376-25b1-48d1-a5a5-5c5a287dfcc7/runs/af12f877-9ba3-4bcf-a909-24c47d796cb8': No such file or directory
```
Looks like the nested container is not always able to use parent's workdir. @Jie, @Gast�n thoughts?
- Alexander Rukletsov
On April 7, 2017, 1:15 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 1:15 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
> src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6
>
>
> Diff: https://reviews.apache.org/r/58263/diff/1/
>
>
> Testing
> -------
>
> make check on Mac OS.
> Linux pending.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review173273
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp
Lines 1504-1506 (original), 1535-1546 (patched)
<https://reviews.apache.org/r/58263/#comment246313>
That makes me think that maybe we should just checkpoint `ContainerLaunchInfo`? That sounds like more extensible?
- Jie Yu
On April 27, 2017, 10:17 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 10:17 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-7433
> https://issues.apache.org/jira/browse/MESOS-7433
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
> src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
> src/slave/containerizer/mesos/paths.hpp d85fd34660faacd9c73de2ba7b87b3bbd4b6007b
> src/slave/containerizer/mesos/paths.cpp ed4bbd2491e71ad1e4a41e0575b514377d02da9b
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82
>
>
> Diff: https://reviews.apache.org/r/58263/diff/3/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/58821/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review173340
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.hpp
Lines 338 (patched)
<https://reviews.apache.org/r/58263/#comment246359>
See my comments in the other review. Let's keep `launchInfo` here (similar to that we keep `config`)
- Jie Yu
On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 4:14 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-7433
> https://issues.apache.org/jira/browse/MESOS-7433
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
> src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82
>
>
> Diff: https://reviews.apache.org/r/58263/diff/4/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/58821/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On May 9, 2017, 6:08 p.m., Gastón Kleiman wrote:
> > src/tests/containerizer/nested_mesos_containerizer_tests.cpp
> > Line 579 (original), 595-598 (patched)
> > <https://reviews.apache.org/r/58263/diff/5-6/?file=1707163#file1707163line595>
> >
> > Why do you prefer not to use the helper method?
Good suggestion.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review174352
-----------------------------------------------------------
On May 10, 2017, 1:54 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 1:54 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-7433
> https://issues.apache.org/jira/browse/MESOS-7433
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto 41f2905df690bfe88ed762f1cd1246689fa4d3ea
> src/slave/containerizer/mesos/containerizer.cpp 3d724945812c0359ed175ce232f70886dc4401c8
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp c163b882fb2fc463537d6906c5a47b24a9a756c4
>
>
> Diff: https://reviews.apache.org/r/58263/diff/7/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/58821/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review174352
-----------------------------------------------------------
Ship it!
src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Line 579 (original), 595-598 (patched)
<https://reviews.apache.org/r/58263/#comment247473>
Why do you prefer not to use the helper method?
- Gastón Kleiman
On May 9, 2017, 2:32 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 2:32 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-7433
> https://issues.apache.org/jira/browse/MESOS-7433
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto 41f2905df690bfe88ed762f1cd1246689fa4d3ea
> src/slave/containerizer/mesos/containerizer.cpp 3d724945812c0359ed175ce232f70886dc4401c8
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp c163b882fb2fc463537d6906c5a47b24a9a756c4
>
>
> Diff: https://reviews.apache.org/r/58263/diff/6/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/58821/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review174376
-----------------------------------------------------------
Ship it!
- Vinod Kone
On May 9, 2017, 2:32 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 2:32 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-7433
> https://issues.apache.org/jira/browse/MESOS-7433
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto 41f2905df690bfe88ed762f1cd1246689fa4d3ea
> src/slave/containerizer/mesos/containerizer.cpp 3d724945812c0359ed175ce232f70886dc4401c8
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp c163b882fb2fc463537d6906c5a47b24a9a756c4
>
>
> Diff: https://reviews.apache.org/r/58263/diff/6/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/58821/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review174575
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 10, 2017, 1:54 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 1:54 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-7433
> https://issues.apache.org/jira/browse/MESOS-7433
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto 41f2905df690bfe88ed762f1cd1246689fa4d3ea
> src/slave/containerizer/mesos/containerizer.cpp 3d724945812c0359ed175ce232f70886dc4401c8
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp c163b882fb2fc463537d6906c5a47b24a9a756c4
>
>
> Diff: https://reviews.apache.org/r/58263/diff/7/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/58821/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/
-----------------------------------------------------------
(Updated May 10, 2017, 1:54 p.m.)
Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
Bugs: MESOS-7433
https://issues.apache.org/jira/browse/MESOS-7433
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/slave/containerizer.proto 41f2905df690bfe88ed762f1cd1246689fa4d3ea
src/slave/containerizer/mesos/containerizer.cpp 3d724945812c0359ed175ce232f70886dc4401c8
src/tests/containerizer/nested_mesos_containerizer_tests.cpp c163b882fb2fc463537d6906c5a47b24a9a756c4
Diff: https://reviews.apache.org/r/58263/diff/7/
Changes: https://reviews.apache.org/r/58263/diff/6-7/
Testing
-------
See https://reviews.apache.org/r/58821/
Thanks,
Alexander Rukletsov
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/
-----------------------------------------------------------
(Updated May 9, 2017, 2:32 p.m.)
Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
Changes
-------
Avoided a potential race in the test.
Bugs: MESOS-7433
https://issues.apache.org/jira/browse/MESOS-7433
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/slave/containerizer.proto 41f2905df690bfe88ed762f1cd1246689fa4d3ea
src/slave/containerizer/mesos/containerizer.cpp 3d724945812c0359ed175ce232f70886dc4401c8
src/tests/containerizer/nested_mesos_containerizer_tests.cpp c163b882fb2fc463537d6906c5a47b24a9a756c4
Diff: https://reviews.apache.org/r/58263/diff/6/
Changes: https://reviews.apache.org/r/58263/diff/5-6/
Testing
-------
See https://reviews.apache.org/r/58821/
Thanks,
Alexander Rukletsov
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/
-----------------------------------------------------------
(Updated May 3, 2017, 4:46 p.m.)
Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
Changes
-------
Moved recovery out of this patch.
Bugs: MESOS-7433
https://issues.apache.org/jira/browse/MESOS-7433
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2
src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82
Diff: https://reviews.apache.org/r/58263/diff/5/
Changes: https://reviews.apache.org/r/58263/diff/4-5/
Testing
-------
See https://reviews.apache.org/r/58821/
Thanks,
Alexander Rukletsov
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On April 28, 2017, 8:49 p.m., Vinod Kone wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Lines 1484 (patched)
> > <https://reviews.apache.org/r/58263/diff/4/?file=1703236#file1703236line1484>
> >
> > Curious if we want to allow isolators to override this behavior for debug containers just like non-debug containers.
A good question. My first thought is not, we would like DEBUG containers to have the same working directory as their parents. On the other side, I don't have enough context to understand or envision cases where an isolator would set work dir to different values for a container and its children.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review173380
-----------------------------------------------------------
On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 4:14 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-7433
> https://issues.apache.org/jira/browse/MESOS-7433
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
> src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82
>
>
> Diff: https://reviews.apache.org/r/58263/diff/4/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/58821/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 28, 2017, 8:49 p.m., Vinod Kone wrote:
> > Nice test.
Modulo Jie's comment.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review173380
-----------------------------------------------------------
On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 4:14 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-7433
> https://issues.apache.org/jira/browse/MESOS-7433
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
> src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82
>
>
> Diff: https://reviews.apache.org/r/58263/diff/4/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/58821/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review173380
-----------------------------------------------------------
Fix it, then Ship it!
Nice test.
src/slave/containerizer/mesos/containerizer.cpp
Lines 1484 (patched)
<https://reviews.apache.org/r/58263/#comment246385>
Curious if we want to allow isolators to override this behavior for debug containers just like non-debug containers.
src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 547 (patched)
<https://reviews.apache.org/r/58263/#comment246386>
s/, also/even/
- Vinod Kone
On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 4:14 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-7433
> https://issues.apache.org/jira/browse/MESOS-7433
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
> src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82
>
>
> Diff: https://reviews.apache.org/r/58263/diff/4/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/58821/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/
-----------------------------------------------------------
(Updated April 28, 2017, 4:14 p.m.)
Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
Changes
-------
Recover via ContainerLaunchInfo.
Bugs: MESOS-7433
https://issues.apache.org/jira/browse/MESOS-7433
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2
src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82
Diff: https://reviews.apache.org/r/58263/diff/4/
Changes: https://reviews.apache.org/r/58263/diff/3-4/
Testing
-------
See https://reviews.apache.org/r/58821/
Thanks,
Alexander Rukletsov
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/
-----------------------------------------------------------
(Updated April 27, 2017, 10:17 p.m.)
Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
Bugs: MESOS-7433
https://issues.apache.org/jira/browse/MESOS-7433
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2
src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
src/slave/containerizer/mesos/paths.hpp d85fd34660faacd9c73de2ba7b87b3bbd4b6007b
src/slave/containerizer/mesos/paths.cpp ed4bbd2491e71ad1e4a41e0575b514377d02da9b
src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82
Diff: https://reviews.apache.org/r/58263/diff/3/
Changes: https://reviews.apache.org/r/58263/diff/2-3/
Testing (updated)
-------
See https://reviews.apache.org/r/58821/
Thanks,
Alexander Rukletsov
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review173064
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58262, 58718, 58263]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 25, 2017, 9:12 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 9:12 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
> src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6
>
>
> Diff: https://reviews.apache.org/r/58263/diff/2/
>
>
> Testing
> -------
>
> make check on Mac OS.
> Linux pending.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/
-----------------------------------------------------------
(Updated April 25, 2017, 9:12 p.m.)
Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6
Diff: https://reviews.apache.org/r/58263/diff/2/
Testing
-------
make check on Mac OS.
Linux pending.
Thanks,
Alexander Rukletsov
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review171372
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58262, 58263]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 7, 2017, 4:19 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 4:19 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
> src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6
>
>
> Diff: https://reviews.apache.org/r/58263/diff/2/
>
>
> Testing
> -------
>
> make check on Mac OS.
> Linux pending.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On April 13, 2017, 12:47 a.m., Vinod Kone wrote:
> > src/slave/containerizer/mesos/containerizer.hpp
> > Lines 325 (patched)
> > <https://reviews.apache.org/r/58263/diff/2/?file=1686501#file1686501line325>
> >
> > Can you elaborate how it is different?
>
> Alexander Rukletsov wrote:
> I can, but I'm not sure this is the right place. I do think we need a proper explanation of the difference, maybe https://github.com/apache/mesos/blob/c702150297da99cc62804aad77057f1948d33714/include/mesos/slave/containerizer.proto#L185-L187 is a better place for this? How about I address it in a separate patch and here I mention we cache the field fron the proto?
Addressed in https://reviews.apache.org/r/58820/
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review171830
-----------------------------------------------------------
On April 25, 2017, 9:12 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 9:12 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
> src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6
>
>
> Diff: https://reviews.apache.org/r/58263/diff/2/
>
>
> Testing
> -------
>
> make check on Mac OS.
> Linux pending.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On April 13, 2017, 12:47 a.m., Vinod Kone wrote:
> > src/slave/containerizer/mesos/containerizer.hpp
> > Lines 325 (patched)
> > <https://reviews.apache.org/r/58263/diff/2/?file=1686501#file1686501line325>
> >
> > Can you elaborate how it is different?
I can, but I'm not sure this is the right place. I do think we need a proper explanation of the difference, maybe https://github.com/apache/mesos/blob/c702150297da99cc62804aad77057f1948d33714/include/mesos/slave/containerizer.proto#L185-L187 is a better place for this? How about I address it in a separate patch and here I mention we cache the field fron the proto?
> On April 13, 2017, 12:47 a.m., Vinod Kone wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Lines 1492 (patched)
> > <https://reviews.apache.org/r/58263/diff/2/?file=1686502#file1686502line1493>
> >
> > don't you need to checkpoint/recover this?
Definitely, it's in the works.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review171830
-----------------------------------------------------------
On April 25, 2017, 9:12 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 9:12 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
> src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6
>
>
> Diff: https://reviews.apache.org/r/58263/diff/2/
>
>
> Testing
> -------
>
> make check on Mac OS.
> Linux pending.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review171830
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.hpp
Lines 325 (patched)
<https://reviews.apache.org/r/58263/#comment244848>
Can you elaborate how it is different?
src/slave/containerizer/mesos/containerizer.cpp
Lines 1492 (patched)
<https://reviews.apache.org/r/58263/#comment244849>
don't you need to checkpoint/recover this?
- Vinod Kone
On April 7, 2017, 4:19 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 4:19 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
> src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6
>
>
> Diff: https://reviews.apache.org/r/58263/diff/2/
>
>
> Testing
> -------
>
> make check on Mac OS.
> Linux pending.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/
-----------------------------------------------------------
(Updated April 7, 2017, 4:19 p.m.)
Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
Changes
-------
Rebased.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6
Diff: https://reviews.apache.org/r/58263/diff/2/
Changes: https://reviews.apache.org/r/58263/diff/1-2/
Testing
-------
make check on Mac OS.
Linux pending.
Thanks,
Alexander Rukletsov
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/
-----------------------------------------------------------
(Updated April 7, 2017, 1:15 p.m.)
Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6
Diff: https://reviews.apache.org/r/58263/diff/1/
Testing (updated)
-------
make check on Mac OS.
Linux pending.
Thanks,
Alexander Rukletsov
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review171331
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58262, 58263]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 7, 2017, 11:05 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 11:05 a.m.)
>
>
> Review request for mesos, Gast�n Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
> src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6
>
>
> Diff: https://reviews.apache.org/r/58263/diff/1/
>
>
> Testing
> -------
>
> make check on Mac OS and various Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>