You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by "xuzifu666 (via GitHub)" <gi...@apache.org> on 2023/06/13 09:30:31 UTC

[GitHub] [hudi] xuzifu666 commented on a diff in pull request #8943: [HUDI-6365] Set hive sync tool only if syncs list is empty

xuzifu666 commented on code in PR #8943:
URL: https://github.com/apache/hudi/pull/8943#discussion_r1227823117


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -897,7 +897,8 @@ object HoodieSparkSqlWriter {
     // for backward compatibility
     if (hiveSyncEnabled) {
       metaSyncEnabled = true
-      syncClientToolClassSet += classOf[HiveSyncTool].getName
+      if (syncClientToolClassSet.isEmpty)

Review Comment:
   when would the set be empty?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org