You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/06/09 14:30:59 UTC
[GitHub] [activemq-artemis] erwindon opened a new pull request #3617: NO-JIRA suggest to use the etc directory for jgroups config, which is already in the classpath and also has all other config files
erwindon opened a new pull request #3617:
URL: https://github.com/apache/activemq-artemis/pull/3617
The documentation suggests to place the jgroups configuration file in the "resource-path".
It is unclear what the resource-path is, or how it can be changed to support a custom directory.
The {{etc}} directory of a broker instance is already in the resource-path and is therefore a natural choice.
The PR updates the documentation so that the instruction is to place the jgroups confile file in the `etc` directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] erwindon commented on a change in pull request #3617: NO-JIRA suggest to use the etc directory for jgroups config, which is already in the classpath and also has all other config files
Posted by GitBox <gi...@apache.org>.
erwindon commented on a change in pull request #3617:
URL: https://github.com/apache/activemq-artemis/pull/3617#discussion_r648554969
##########
File path: docs/user-manual/en/clusters.md
##########
@@ -161,8 +161,8 @@ i.e. `jgroups-file` and `jgroups-channel`, as discussed in details as
following:
- `jgroups-file` attribute. This is the name of JGroups configuration
- file. It will be used to initialize JGroups channels. Make sure the
- file is in the java resource path so that Apache ActiveMQ Artemis can load it.
+ file. It will be used to initialize JGroups channels. Place the file
+ in the `etc` directory of the broker instance so that Apache ActiveMQ Artemis can load it.
Review comment:
@brusdev That did cross my mind. But no other locations are in the classpath as far as I know. The start-script starts with one single JAR in the classpath and the bootstrap code add all the JAR+ZIP files from and also the 2 `lib` and 2 `etc` directories. There is little choice in choosing the location for the jgroups config file. And also the jgroups config file is most likely instance-specific. And also note the comment in `artemis-boot/src/main/java/org/apache/activemq/artemis/boot/Artemis.java`:
```java
// Without the etc on the config, things like JGroups configuration wouldn't be loaded
```
True, my text is only about the `etc` directory for the instance. So let's improve that, because I still think that "java resource path" is too confusing.
my proposal:
* keep the original text; and
* add: "The typical location for the file is the `etc` directory from the broker instance."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on a change in pull request #3617: NO-JIRA suggest to use the etc directory for jgroups config, which is already in the classpath and also has all other config files
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3617:
URL: https://github.com/apache/activemq-artemis/pull/3617#discussion_r648463887
##########
File path: docs/user-manual/en/clusters.md
##########
@@ -161,8 +161,8 @@ i.e. `jgroups-file` and `jgroups-channel`, as discussed in details as
following:
- `jgroups-file` attribute. This is the name of JGroups configuration
- file. It will be used to initialize JGroups channels. Make sure the
- file is in the java resource path so that Apache ActiveMQ Artemis can load it.
+ file. It will be used to initialize JGroups channels. Place the file
+ in the `etc` directory of the broker instance so that Apache ActiveMQ Artemis can load it.
Review comment:
I would keep the previous option too. Reading the new doc it seems we can only place the file in the `etc` directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3617: NO-JIRA suggest to use the etc directory for jgroups config, which is already in the classpath and also has all other config files
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3617:
URL: https://github.com/apache/activemq-artemis/pull/3617#issuecomment-858458368
Seems reasonable to me. Squash the commits and rebase against main, and add the JIRA ref to the PR title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] erwindon edited a comment on pull request #3617: ARTEMIS-3334 suggest to use the etc directory for jgroups config, which is already in the classpath and also has all other config files
Posted by GitBox <gi...@apache.org>.
erwindon edited a comment on pull request #3617:
URL: https://github.com/apache/activemq-artemis/pull/3617#issuecomment-858499436
title is changed --> done
2 commits are now squashed into one --> done
rebased on the current main --> done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] erwindon commented on pull request #3617: ARTEMIS-3334 suggest to use the etc directory for jgroups config, which is already in the classpath and also has all other config files
Posted by GitBox <gi...@apache.org>.
erwindon commented on pull request #3617:
URL: https://github.com/apache/activemq-artemis/pull/3617#issuecomment-858499436
title is changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic merged pull request #3617: ARTEMIS-3334 suggest to use the etc directory for jgroups config, which is already in the classpath and also has all other config files
Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3617:
URL: https://github.com/apache/activemq-artemis/pull/3617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] erwindon edited a comment on pull request #3617: ARTEMIS-3334 suggest to use the etc directory for jgroups config, which is already in the classpath and also has all other config files
Posted by GitBox <gi...@apache.org>.
erwindon edited a comment on pull request #3617:
URL: https://github.com/apache/activemq-artemis/pull/3617#issuecomment-858499436
title is changed
2 commits are now squashed into one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org