You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by zi...@apache.org on 2022/07/27 10:12:23 UTC
[pulsar] branch master updated: [refactor][test] Use logger to print log (#16798)
This is an automated email from the ASF dual-hosted git repository.
zike pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 5df15dd2edd [refactor][test] Use logger to print log (#16798)
5df15dd2edd is described below
commit 5df15dd2edd7eeab309fea35828915c8698ea339
Author: Zike Yang <zi...@apache.org>
AuthorDate: Wed Jul 27 18:12:17 2022 +0800
[refactor][test] Use logger to print log (#16798)
### Motivation
Need to use the logger to print logs in the unit test.
### Modifications
* Use logger instead of `System.out`.
---
.../java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
index 8e53a15b066..81c35f4db77 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
@@ -270,7 +270,7 @@ public class PersistentTopicsTest extends MockedPulsarServiceBaseTest {
// 1) produce numberOfMessages message to pulsar
for (int i = 0; i < numberOfMessages; i++) {
- System.out.println(producer.send(new byte[10]));
+ log.info("Produce messages: " + producer.send(new byte[10]).toString());
}
// 2) Create a subscription from earliest position
@@ -288,7 +288,7 @@ public class PersistentTopicsTest extends MockedPulsarServiceBaseTest {
verify(response, timeout(5000).times(1)).resume(statCaptor.capture());
TopicStats topicStats = statCaptor.getValue();
long msgBacklog = topicStats.getSubscriptions().get(SUB_EARLIEST).getMsgBacklog();
- System.out.println("Message back log for " + SUB_EARLIEST + " is :" + msgBacklog);
+ log.info("Message back log for " + SUB_EARLIEST + " is :" + msgBacklog);
Assert.assertEquals(msgBacklog, numberOfMessages);
// 3) Create a subscription with form latest position
@@ -306,7 +306,7 @@ public class PersistentTopicsTest extends MockedPulsarServiceBaseTest {
verify(response, timeout(5000).times(1)).resume(statCaptor.capture());
topicStats = statCaptor.getValue();
msgBacklog = topicStats.getSubscriptions().get(SUB_LATEST).getMsgBacklog();
- System.out.println("Message back log for " + SUB_LATEST + " is :" + msgBacklog);
+ log.info("Message back log for " + SUB_LATEST + " is :" + msgBacklog);
Assert.assertEquals(msgBacklog, 0);
// 4) Create a subscription without position
@@ -324,7 +324,7 @@ public class PersistentTopicsTest extends MockedPulsarServiceBaseTest {
verify(response, timeout(5000).times(1)).resume(statCaptor.capture());
topicStats = statCaptor.getValue();
msgBacklog = topicStats.getSubscriptions().get(SUB_NONE_MESSAGE_ID).getMsgBacklog();
- System.out.println("Message back log for " + SUB_NONE_MESSAGE_ID + " is :" + msgBacklog);
+ log.info("Message back log for " + SUB_NONE_MESSAGE_ID + " is :" + msgBacklog);
Assert.assertEquals(msgBacklog, 0);
// 5) Create replicated subscription