[GitHub] [hive] pvargacl commented on a change in pull request #1618: Do not remove metadata for aborted writes that were batched with valid ones in the same delta file

[GitBox <gi...@apache.org>]

pvargacl commented on a change in pull request #1618:
URL: https://github.com/apache/hive/pull/1618#discussion_r513630373



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -263,7 +271,7 @@ private void removeFiles(String location, ValidWriteIdList writeIdList, Compacti
     if (filesToDelete.size() < 1) {
       LOG.warn("Hmm, nothing to delete in the cleaner for directory " + location +
           ", that hardly seems right.");
-      return;
+      return false;

Review comment:
       I don't think this check helps. The dynamic partitioning case does a table level scan no? It might just find a single aborted dir in some of the old partitions that it can clean up, it does not mean, that it did not skip streaming deltas with aborted + commited txns.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org