You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/11 10:03:05 UTC
[GitHub] [flink] PatrickRen opened a new pull request #18328: [BP-1.13][FLINK-25280][connector/kafka] Disable log deletion in KafkaTestEnvironmentImpl to prevent records from being deleted during test run
PatrickRen opened a new pull request #18328:
URL: https://github.com/apache/flink/pull/18328
Unchanged backport of #18311 on release-1.13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18328: [BP-1.13][FLINK-25280][connector/kafka] Disable log deletion in KafkaTestEnvironmentImpl to prevent records from being deleted during test run
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18328:
URL: https://github.com/apache/flink/pull/18328#issuecomment-1009792680
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 40db5179952cbc26cc983959acd9bf7953440c01 (Tue Jan 11 10:08:39 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-25280).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18328: [BP-1.13][FLINK-25280][connector/kafka] Disable log deletion in KafkaTestEnvironmentImpl to prevent records from being deleted during test run
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18328:
URL: https://github.com/apache/flink/pull/18328#issuecomment-1009793713
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "40db5179952cbc26cc983959acd9bf7953440c01",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "40db5179952cbc26cc983959acd9bf7953440c01",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 40db5179952cbc26cc983959acd9bf7953440c01 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18328: [BP-1.13][FLINK-25280][connector/kafka] Disable log deletion in KafkaTestEnvironmentImpl to prevent records from being deleted during test run
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18328:
URL: https://github.com/apache/flink/pull/18328#issuecomment-1009793713
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "40db5179952cbc26cc983959acd9bf7953440c01",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29250",
"triggerID" : "40db5179952cbc26cc983959acd9bf7953440c01",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 40db5179952cbc26cc983959acd9bf7953440c01 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29250)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul merged pull request #18328: [BP-1.13][FLINK-25280][connector/kafka] Disable log deletion in KafkaTestEnvironmentImpl to prevent records from being deleted during test run
Posted by GitBox <gi...@apache.org>.
fapaul merged pull request #18328:
URL: https://github.com/apache/flink/pull/18328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18328: [BP-1.13][FLINK-25280][connector/kafka] Disable log deletion in KafkaTestEnvironmentImpl to prevent records from being deleted during test run
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18328:
URL: https://github.com/apache/flink/pull/18328#issuecomment-1009793713
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "40db5179952cbc26cc983959acd9bf7953440c01",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29250",
"triggerID" : "40db5179952cbc26cc983959acd9bf7953440c01",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 40db5179952cbc26cc983959acd9bf7953440c01 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29250)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org