You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Timothy Potter <th...@gmail.com> on 2015/07/29 19:00:47 UTC
Strange comment in CdcrReplicationHandlerTest.java
Why is this in the code?
/**
* Copyright (c) 2015 Renaud Delbru. All Rights Reserved.
*/
package org.apache.solr.cloud;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
RE: Strange comment in CdcrReplicationHandlerTest.java
Posted by "Ramkumar R. Aiyengar" <an...@gmail.com>.
Ah okay, my bad then..
On 29 Jul 2015 21:28, "Uwe Schindler" <uw...@thetaphi.de> wrote:
> RAT would only fail if the license header is missing completely. I don't
> think it checks for "copyright notices".
>
> If there is no license header, we should check our RAT config! What does
> it list as license for that file?
>
> Uwe
>
> -----
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetaphi.de
> eMail: uwe@thetaphi.de
>
>
> > -----Original Message-----
> > From: Erick Erickson [mailto:erickerickson@gmail.com]
> > Sent: Wednesday, July 29, 2015 7:36 PM
> > To: dev@lucene.apache.org
> > Subject: Re: Strange comment in CdcrReplicationHandlerTest.java
> >
> > Yeah, I wondered that myself.
> >
> > On Wed, Jul 29, 2015 at 1:35 PM, Ramkumar R. Aiyengar
> > <an...@gmail.com> wrote:
> > > Hmm.. I would have expected rat to fail this in precommit actually..
> > >
> > > On 29 Jul 2015 18:01, "Timothy Potter" <th...@gmail.com> wrote:
> > >>
> > >> Why is this in the code?
> > >>
> > >> /**
> > >> * Copyright (c) 2015 Renaud Delbru. All Rights Reserved.
> > >> */
> > >> package org.apache.solr.cloud;
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For
> > >> additional commands, e-mail: dev-help@lucene.apache.org
> > >>
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
> > commands, e-mail: dev-help@lucene.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
Re: Strange comment in CdcrReplicationHandlerTest.java
Posted by Renaud Delbru <re...@sindicetech.com>.
Yes, my apologies for this, I didn't catch this one when I reviewed the
code before commit.
--
Renaud Delbru
On 29/07/15 23:29, Erick Erickson wrote:
> Standard apache license, this was just a couple of erroneous lines at the top,
> I suspect auto-added to by his IDE, I messed it too.
>
> Will fix this in the next week, I'm traveling right now.
>
> To Whit.
>
> /*
> * Licensed to the Apache Software Foundation (ASF) under one or more
> * contributor license agreements. See the NOTICE file distributed with
> * this work for additional information regarding copyright ownership.
> * The ASF licenses this file to You under the Apache License, Version 2.0
> * (the "License"); you may not use this file except in compliance with
> * the License. You may obtain a copy of the License at
> *
> * http://www.apache.org/licenses/LICENSE-2.0
> *
> * Unless required by applicable law or agreed to in writing, software
> * distributed under the License is distributed on an "AS IS" BASIS,
> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> * See the License for the specific language governing permissions and
> * limitations under the License.
> */
>
> On Wed, Jul 29, 2015 at 4:27 PM, Uwe Schindler <uw...@thetaphi.de> wrote:
>> RAT would only fail if the license header is missing completely. I don't think it checks for "copyright notices".
>>
>> If there is no license header, we should check our RAT config! What does it list as license for that file?
>>
>> Uwe
>>
>> -----
>> Uwe Schindler
>> H.-H.-Meier-Allee 63, D-28213 Bremen
>> http://www.thetaphi.de
>> eMail: uwe@thetaphi.de
>>
>>
>>> -----Original Message-----
>>> From: Erick Erickson [mailto:erickerickson@gmail.com]
>>> Sent: Wednesday, July 29, 2015 7:36 PM
>>> To: dev@lucene.apache.org
>>> Subject: Re: Strange comment in CdcrReplicationHandlerTest.java
>>>
>>> Yeah, I wondered that myself.
>>>
>>> On Wed, Jul 29, 2015 at 1:35 PM, Ramkumar R. Aiyengar
>>> <an...@gmail.com> wrote:
>>>> Hmm.. I would have expected rat to fail this in precommit actually..
>>>>
>>>> On 29 Jul 2015 18:01, "Timothy Potter" <th...@gmail.com> wrote:
>>>>>
>>>>> Why is this in the code?
>>>>>
>>>>> /**
>>>>> * Copyright (c) 2015 Renaud Delbru. All Rights Reserved.
>>>>> */
>>>>> package org.apache.solr.cloud;
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For
>>>>> additional commands, e-mail: dev-help@lucene.apache.org
>>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
>>> commands, e-mail: dev-help@lucene.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Strange comment in CdcrReplicationHandlerTest.java
Posted by Erick Erickson <er...@gmail.com>.
Standard apache license, this was just a couple of erroneous lines at the top,
I suspect auto-added to by his IDE, I messed it too.
Will fix this in the next week, I'm traveling right now.
To Whit.
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
On Wed, Jul 29, 2015 at 4:27 PM, Uwe Schindler <uw...@thetaphi.de> wrote:
> RAT would only fail if the license header is missing completely. I don't think it checks for "copyright notices".
>
> If there is no license header, we should check our RAT config! What does it list as license for that file?
>
> Uwe
>
> -----
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetaphi.de
> eMail: uwe@thetaphi.de
>
>
>> -----Original Message-----
>> From: Erick Erickson [mailto:erickerickson@gmail.com]
>> Sent: Wednesday, July 29, 2015 7:36 PM
>> To: dev@lucene.apache.org
>> Subject: Re: Strange comment in CdcrReplicationHandlerTest.java
>>
>> Yeah, I wondered that myself.
>>
>> On Wed, Jul 29, 2015 at 1:35 PM, Ramkumar R. Aiyengar
>> <an...@gmail.com> wrote:
>> > Hmm.. I would have expected rat to fail this in precommit actually..
>> >
>> > On 29 Jul 2015 18:01, "Timothy Potter" <th...@gmail.com> wrote:
>> >>
>> >> Why is this in the code?
>> >>
>> >> /**
>> >> * Copyright (c) 2015 Renaud Delbru. All Rights Reserved.
>> >> */
>> >> package org.apache.solr.cloud;
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For
>> >> additional commands, e-mail: dev-help@lucene.apache.org
>> >>
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
>> commands, e-mail: dev-help@lucene.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
RE: Strange comment in CdcrReplicationHandlerTest.java
Posted by Uwe Schindler <uw...@thetaphi.de>.
RAT would only fail if the license header is missing completely. I don't think it checks for "copyright notices".
If there is no license header, we should check our RAT config! What does it list as license for that file?
Uwe
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
> -----Original Message-----
> From: Erick Erickson [mailto:erickerickson@gmail.com]
> Sent: Wednesday, July 29, 2015 7:36 PM
> To: dev@lucene.apache.org
> Subject: Re: Strange comment in CdcrReplicationHandlerTest.java
>
> Yeah, I wondered that myself.
>
> On Wed, Jul 29, 2015 at 1:35 PM, Ramkumar R. Aiyengar
> <an...@gmail.com> wrote:
> > Hmm.. I would have expected rat to fail this in precommit actually..
> >
> > On 29 Jul 2015 18:01, "Timothy Potter" <th...@gmail.com> wrote:
> >>
> >> Why is this in the code?
> >>
> >> /**
> >> * Copyright (c) 2015 Renaud Delbru. All Rights Reserved.
> >> */
> >> package org.apache.solr.cloud;
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For
> >> additional commands, e-mail: dev-help@lucene.apache.org
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
> commands, e-mail: dev-help@lucene.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Strange comment in CdcrReplicationHandlerTest.java
Posted by Erick Erickson <er...@gmail.com>.
Yeah, I wondered that myself.
On Wed, Jul 29, 2015 at 1:35 PM, Ramkumar R. Aiyengar
<an...@gmail.com> wrote:
> Hmm.. I would have expected rat to fail this in precommit actually..
>
> On 29 Jul 2015 18:01, "Timothy Potter" <th...@gmail.com> wrote:
>>
>> Why is this in the code?
>>
>> /**
>> * Copyright (c) 2015 Renaud Delbru. All Rights Reserved.
>> */
>> package org.apache.solr.cloud;
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Strange comment in CdcrReplicationHandlerTest.java
Posted by "Ramkumar R. Aiyengar" <an...@gmail.com>.
Hmm.. I would have expected rat to fail this in precommit actually..
On 29 Jul 2015 18:01, "Timothy Potter" <th...@gmail.com> wrote:
> Why is this in the code?
>
> /**
> * Copyright (c) 2015 Renaud Delbru. All Rights Reserved.
> */
> package org.apache.solr.cloud;
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
Re: Strange comment in CdcrReplicationHandlerTest.java
Posted by Erick Erickson <er...@gmail.com>.
Thanks, got it. I'll be putting some stuff up and this'll be fixed then.
Erick
On Wed, Jul 29, 2015 at 1:00 PM, Timothy Potter <th...@gmail.com> wrote:
> Why is this in the code?
>
> /**
> * Copyright (c) 2015 Renaud Delbru. All Rights Reserved.
> */
> package org.apache.solr.cloud;
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org