You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2015/04/18 16:05:56 UTC
svn commit: r1674511 - in /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox: cos/COSFloat.java cos/COSNull.java pdfwriter/COSWriter.java

Author: tilman
Date: Sat Apr 18 14:05:56 2015
New Revision: 1674511

URL: http://svn.apache.org/r1674511
Log:
PDFBOX-2576: revert "make methods static" changes due to lack of consensus

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSFloat.java
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSNull.java
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSFloat.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSFloat.java?rev=1674511&r1=1674510&r2=1674511&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSFloat.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSFloat.java Sat Apr 18 14:05:56 2015
@@ -64,7 +64,7 @@ public class COSFloat extends COSNumber
         }
     }
 
-    private static String removeNullDigits(String plainStringValue)
+    private String removeNullDigits(String plainStringValue)
     {
         // remove fraction digit "0" only
         if (plainStringValue.indexOf('.') > -1 && !plainStringValue.endsWith(".0"))

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSNull.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSNull.java?rev=1674511&r1=1674510&r2=1674511&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSNull.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSNull.java Sat Apr 18 14:05:56 2015
@@ -63,7 +63,7 @@ public final class COSNull extends COSBa
      * @param output The stream to write to.
      * @throws IOException If there is an error writing to the stream.
      */
-    public static void writePDF( OutputStream output ) throws IOException
+    public void writePDF( OutputStream output ) throws IOException
     {
         output.write(NULL_BYTES);
     }

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java?rev=1674511&r1=1674510&r2=1674511&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/COSWriter.java Sat Apr 18 14:05:56 2015
@@ -1089,7 +1089,7 @@ public class COSWriter implements ICOSVi
     @Override
     public Object visitFromNull(COSNull obj) throws IOException
     {
-        COSNull.writePDF(getStandardOutput());
+        obj.writePDF(getStandardOutput());
         return null;
     }