You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/07/15 11:57:41 UTC
[GitHub] [hive] lcspinter opened a new pull request, #3445: HIVE-26397: Honour Iceberg sort orders when writing a table
lcspinter opened a new pull request, #3445:
URL: https://github.com/apache/hive/pull/3445
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Consider iceberg sort-order param when writing out data files.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Unit test, manual test
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3445: HIVE-26397: Honour Iceberg sort orders when writing a table
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3445:
URL: https://github.com/apache/hive/pull/3445#discussion_r924461104
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -334,24 +338,32 @@ public boolean supportsPartitionTransform() {
public List<PartitionTransformSpec> getPartitionTransformSpec(org.apache.hadoop.hive.ql.metadata.Table hmsTable) {
TableDesc tableDesc = Utilities.getTableDesc(hmsTable);
Table table = IcebergTableUtil.getTable(conf, tableDesc.getProperties());
- return table.spec().fields().stream().map(f -> {
- PartitionTransformSpec spec = new PartitionTransformSpec();
- spec.setColumnName(table.schema().findColumnName(f.sourceId()));
- // right now the only way to fetch the transform type and its params is through the toString() call
- String transformName = f.transform().toString().toUpperCase();
- // if the transform name contains '[' it means it has some config params
- if (transformName.contains("[")) {
- spec.setTransformType(PartitionTransformSpec.TransformType
- .valueOf(transformName.substring(0, transformName.indexOf("["))));
- spec.setTransformParam(Optional.of(Integer
- .valueOf(transformName.substring(transformName.indexOf("[") + 1, transformName.indexOf("]")))));
- } else {
- spec.setTransformType(PartitionTransformSpec.TransformType.valueOf(transformName));
- spec.setTransformParam(Optional.empty());
- }
+ return table.spec().fields().stream().map(f ->
+ getTransformSpec(table, f.transform().toString().toUpperCase(), f.sourceId())
+ ).collect(Collectors.toList());
+ }
+
+ private List<PartitionTransformSpec> getSortTransformSpec(Table table) {
Review Comment:
Should we rename the `PartitionTransformSpec` to something more appropriate?
Are we able to handle every sort mode defined by Iceberg?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3445: HIVE-26397: Honour Iceberg sort orders when writing a table
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3445:
URL: https://github.com/apache/hive/pull/3445#discussion_r924463757
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -682,7 +740,7 @@ public static Schema schema(Configuration config) {
}
/**
- * Stores the serializable table data in the configuration.
+ * Stores the serializable table data in the configuration
Review Comment:
Why is this change?
BTW Javadoc expect `.` at the end of the first sentence... at least I remember somewhere fighting with adding extra dots at the end of the lines 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3445: HIVE-26397: Honour Iceberg sort orders when writing a table
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3445:
URL: https://github.com/apache/hive/pull/3445#discussion_r924468260
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -346,6 +346,23 @@ default List<FieldSchema> acidSortColumns(org.apache.hadoop.hive.ql.metadata.Tab
return Collections.emptyList();
}
+ /**
+ * Check if the underlying storage handler implementation supports sort columns.
+ * @return true if the storage handler can support it
+ */
+ default boolean supportsSortColumns() {
+ return false;
+ }
+
+ /**
+ * Collect the columns that are used to sort the content of the data files
+ * @param table the table which is being sorted
+ * @return the list of columns that are used during data sorting
+ */
+ default List<FieldSchema> sortColumns(org.apache.hadoop.hive.ql.metadata.Table table) {
+ return Collections.emptyList();
Review Comment:
Shall we throw an exception here, to find issues sooner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a diff in pull request #3445: HIVE-26397: Honour Iceberg sort orders when writing a table
Posted by GitBox <gi...@apache.org>.
pvary commented on code in PR #3445:
URL: https://github.com/apache/hive/pull/3445#discussion_r924469139
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java:
##########
@@ -77,16 +68,25 @@
import org.apache.hadoop.hive.ql.plan.SelectDesc;
import org.apache.hadoop.hive.ql.plan.Statistics;
import org.apache.hadoop.hive.ql.plan.TableDesc;
+import org.apache.hadoop.hive.serde2.typeinfo.PrimitiveTypeInfo;
import org.apache.hadoop.hive.serde2.typeinfo.TypeInfo;
import org.apache.hadoop.hive.serde2.typeinfo.TypeInfoFactory;
-import org.apache.hadoop.hive.serde2.typeinfo.PrimitiveTypeInfo;
import org.apache.orc.OrcConf;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import com.google.common.collect.Lists;
-import com.google.common.collect.Maps;
-import com.google.common.collect.Sets;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.LinkedHashMap;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.Stack;
+import java.util.function.Function;
+import java.util.stream.Collectors;
Review Comment:
This reordering of imports probably not necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] lcspinter commented on a diff in pull request #3445: HIVE-26397: Honour Iceberg sort orders when writing a table
Posted by GitBox <gi...@apache.org>.
lcspinter commented on code in PR #3445:
URL: https://github.com/apache/hive/pull/3445#discussion_r925245767
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -334,24 +338,32 @@ public boolean supportsPartitionTransform() {
public List<PartitionTransformSpec> getPartitionTransformSpec(org.apache.hadoop.hive.ql.metadata.Table hmsTable) {
TableDesc tableDesc = Utilities.getTableDesc(hmsTable);
Table table = IcebergTableUtil.getTable(conf, tableDesc.getProperties());
- return table.spec().fields().stream().map(f -> {
- PartitionTransformSpec spec = new PartitionTransformSpec();
- spec.setColumnName(table.schema().findColumnName(f.sourceId()));
- // right now the only way to fetch the transform type and its params is through the toString() call
- String transformName = f.transform().toString().toUpperCase();
- // if the transform name contains '[' it means it has some config params
- if (transformName.contains("[")) {
- spec.setTransformType(PartitionTransformSpec.TransformType
- .valueOf(transformName.substring(0, transformName.indexOf("["))));
- spec.setTransformParam(Optional.of(Integer
- .valueOf(transformName.substring(transformName.indexOf("[") + 1, transformName.indexOf("]")))));
- } else {
- spec.setTransformType(PartitionTransformSpec.TransformType.valueOf(transformName));
- spec.setTransformParam(Optional.empty());
- }
+ return table.spec().fields().stream().map(f ->
+ getTransformSpec(table, f.transform().toString().toUpperCase(), f.sourceId())
+ ).collect(Collectors.toList());
+ }
+
+ private List<PartitionTransformSpec> getSortTransformSpec(Table table) {
Review Comment:
I will rename it to something more general, like `TransformSpec`.
Yes, we are able to handle every kind of sort-order definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] lcspinter merged pull request #3445: HIVE-26397: Honour Iceberg sort orders when writing a table
Posted by GitBox <gi...@apache.org>.
lcspinter merged PR #3445:
URL: https://github.com/apache/hive/pull/3445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org