You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/18 02:33:03 UTC

[GitHub] [beam] amaliujia edited a comment on pull request #14010: [BEAM-11747] Disable BeamJavaUdfCalcRule by default.

amaliujia edited a comment on pull request #14010:
URL: https://github.com/apache/beam/pull/14010#issuecomment-780999605


   To conclude a bit, right now there are two concerns:
   
   1. The planner might generate multiple plans thus lead to data corruption.
   I am not convinced by this concern because the internal compliance test is consistently passing.  
   
   2. If Java UDF runs with data types in BeamCalcRel that can be compatible. 
   See https://github.com/apache/beam/pull/13898#issuecomment-780950443. The UDF execution is much easier than built-in operations in BeamCalRel. However I am ok to use #13898 as a strict constraints for now and we can loose the constraint  later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org