[GitHub] [madlib] hpandeycodeit commented on a change in pull request #432: MADLIB-1351 : Added stopping criteria on perplexity to LDA

[GitBox <gi...@apache.org>]

hpandeycodeit commented on a change in pull request #432: MADLIB-1351 : Added stopping criteria on perplexity to LDA
URL: https://github.com/apache/madlib/pull/432#discussion_r321871239
 
 

 ##########
 File path: src/ports/postgres/modules/lda/lda.py_in
 ##########
 @@ -445,6 +511,12 @@ def lda_train(schema_madlib, train_table, model_table, output_data_table, voc_si
             'invalid argument: positive real expected for alpha')
     _assert(beta is not None and beta > 0,
             'invalid argument: positive real expected for beta')
+    _assert(evaluate_every is not None and evaluate_every >= 0,
 
 Review comment:
   I have removed this check as we are not calculating the perplexity for 0 or -1. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services