You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/09/09 02:02:41 UTC

Review Request 38193: Remove comment from updateAllocation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38193/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

The allocation for updateAllocation will always be updated after
reserve, unreserve, create and destroy, so there is no need to
add the TODO comments of "Do not log if there is no update".


Diffs
-----

  src/master/allocator/mesos/hierarchical.hpp cb4020dea897ef198cd9898cabecf61edfade834 

Diff: https://reviews.apache.org/r/38193/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 38193: Remove comment from updateAllocation

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38193/#review98122
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On Sept. 9, 2015, 12:02 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38193/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 12:02 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The allocation for updateAllocation will always be updated after
> reserve, unreserve, create and destroy, so there is no need to
> add the TODO comments of "Do not log if there is no update".
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp cb4020dea897ef198cd9898cabecf61edfade834 
> 
> Diff: https://reviews.apache.org/r/38193/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>