You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by kevinjqiu <gi...@git.apache.org> on 2017/01/19 03:09:57 UTC
[GitHub] couchdb-fauxton pull request #837: Add an ETA field for active tasks tab
GitHub user kevinjqiu opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/837
Add an ETA field for active tasks tab
- Show ETA for active tasks if possible (N/A if not)
- Show rate of change
Screenshot attached:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevinjqiu/couchdb-fauxton display-active-tasks-eta
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/837.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #837
----
commit f23fb2e89950cab9378556ebf60b729fd4f2b4d7
Author: Kevin Jing Qiu <ke...@idempotent.ca>
Date: 2017-01-16T20:47:47Z
Calculate and display the ETA for tasks
commit 8e6eb4c0e855bf74cb2bb1786e4df43646a1d794
Author: Kevin Jing Qiu <ke...@idempotent.ca>
Date: 2017-01-16T21:01:35Z
Update test
commit 12697c9d1eb86dec0429aa43bc8304d8909d61a6
Author: Kevin Jing Qiu <ke...@idempotent.ca>
Date: 2017-01-16T21:27:39Z
Display N/A when ETA is not available
commit 9a7ea58b4184de1b7e04103280f3a8e01ce75b36
Author: Kevin Jing Qiu <ke...@idempotent.ca>
Date: 2017-01-16T21:30:35Z
Return value should be an array
commit 2a430b0f8943dfa497cf129b15852e8dffa79e3d
Author: Kevin Jing Qiu <ke...@idempotent.ca>
Date: 2017-01-18T19:58:01Z
Display N/A when rate is not available
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #837: Add an ETA field for active tasks tab
Posted by kevinjqiu <gi...@git.apache.org>.
Github user kevinjqiu commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/837
@garrensmith Thanks for the reply. It's accurate as of the moment the stats is pulled (from `/_active_tasks`) and is calculated. If the rate of change varies significantly from one moment to the other, then the estimate is going to fluctuate. As per my testing, when the rate of change stabilizes, the estimate is more accurate.
That said, the estimate is an estimate after all, and is as good as the data it can work with. As long as the users are aware of the fact the ETA is calculated given the data at that moment, I think it's a good piece of information to show :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #837: Add an ETA field for active tasks tab
Posted by justin-mcdavid-ibm <gi...@git.apache.org>.
Github user justin-mcdavid-ibm commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/837
@kevinjqiu great idea and work. If we add ETA, though, I think it might make sense to re-order the display of information slightly. Placing **Started on** and **Estimated Completion** side-by-side would make it easier to make quick relative comparisons. And it might make sense to add the **Updated on** value to the value list in the **Status** column-- which would mean that the display on smaller screens (like mine) wouldn't be squished by the addition of a new column.
Thanks for the work on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #837: Add an ETA field for active tasks tab
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/837
@kevinjqiu thanks for this PR. Its great that you are contributing. The only thing is how accurate do you think that ETA is? Do we want to show users an ETA where we cannot guarantee the accuracy of.
@rnewson and @janl I would love your thoughts on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #837: Add an ETA field for active tasks tab
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/837
Awesome. Let me know if I can help in anyway
On 20 Jan 2017, 6:30 PM +0200, Kevin J. Qiu <no...@github.com>, wrote:
> @garrensmith Yeah that's a good idea.
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #837: Add an ETA field for active tasks tab
Posted by kevinjqiu <gi...@git.apache.org>.
Github user kevinjqiu commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/837
@garrensmith Yeah that's a good idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #837: Add an ETA field for active tasks tab
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/837
@rnewson brings up a really good point. Since active tasks is polling in the background. Instead of calculating the ETA on one request. Could you rather wait for say 3 - 5 requests and then do an aggregate calculation for the ETA. I think that will stabilise the ETA a bit and make it a little more consistent between active task refreshes.
You could use local storage/pouchdb to keep a list of previous ETA's so that whenever the user views the active tasks page they immediately get an ETA for a long running task.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #837: Add an ETA field for active tasks tab
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/837
We had something like this in the old cloudant dashboard (quite some time ago). My experience is that it's initial ETA was wildly inaccurate, based on a single _active_tasks call, but warmed up as it saw more data. I suggest that this approach be followed in fauxton.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---