[GitHub] sijie commented on a change in pull request #510: Issue-605 BP-15 New CreateLedger API

[gi...@git.apache.org]

sijie commented on a change in pull request #510: Issue-605 BP-15 New CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r139511063
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/CreateAdvBuilder.java
 ##########
 @@ -0,0 +1,36 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *pa
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.bookkeeper.client.api;
+
+import java.util.concurrent.CompletableFuture;
+import org.apache.bookkeeper.client.AsyncCallback.CreateCallback;
+import org.apache.bookkeeper.client.BKException;
+
+/**
+ * Builder-style interface to create new ledgers
+ */
+public interface CreateAdvBuilder {
+
+    CreateAdvBuilder withLedgerId(int ledgerId);
+
+    WriteAdvHandler create() throws BKException, InterruptedException;
+
+    CompletableFuture<WriteAdvHandler> execute();
+
+    void create(CreateCallback cb, Object ctx);
 
 Review comment:
   I think fewer methods to execute a operation will be clean and better. so if we can have only one async method, that would be great!
   
   regarding ExecutionException, you can always have a FutureUtils to wait CompletableFuture result and handle ExecutionException. this is how we did in distributedlog.
   
   https://github.com/apache/distributedlog/blob/master/distributedlog-common/src/main/java/org/apache/distributedlog/common/concurrent/FutureUtils.java#L60
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services